fix(page-has-main): do not find hidden elements (#2001)

dequelabs · Jan 29, 2020 · 6429e60 · 6429e60
1 parent a8d829e
commit 6429e60
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/checks/keyboard/page-has-elm.js b/lib/checks/keyboard/page-has-elm.js
@@ -4,6 +4,10 @@ if (!options || !options.selector || typeof options.selector !== 'string') {
 	);
 }
 
-const matchingElms = axe.utils.querySelectorAll(virtualNode, options.selector);
+const matchingElms = axe.utils.querySelectorAllFilter(
+	virtualNode,
+	options.selector,
+	vNode => axe.commons.dom.isVisible(vNode.actualNode)
+);
 this.relatedNodes(matchingElms.map(vNode => vNode.actualNode));
 return matchingElms.length > 0;
diff --git a/test/checks/keyboard/page-has-elm.js b/test/checks/keyboard/page-has-elm.js
@@ -45,6 +45,15 @@ describe('page-has-*', function() {
 			var params = checkSetup('<div id="target"><b>No role</b></div>', options);
 			assert.isFalse(evaluate.apply(checkContext, params));
 		});
+
+		it('does not find hidden elements', function() {
+			var options = { selector: 'b' };
+			var params = checkSetup(
+				'<div id="target"><b style="display: none;">No role</b></div>',
+				options
+			);
+			assert.isFalse(evaluate.apply(checkContext, params));
+		});
 	});
 
 	describe('after', function() {