Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button-name): input[role=button] with value should pass #1897

Merged
merged 1 commit into from Nov 14, 2019
Merged

fix(button-name): input[role=button] with value should pass #1897

merged 1 commit into from Nov 14, 2019

Conversation

WilcoFiers
Copy link
Contributor

@WilcoFiers WilcoFiers commented Nov 13, 2019 •
edited by straker

Closes issue: #1892

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@WilcoFiers WilcoFiers requested a review from a team as a code owner November 13, 2019 15:24
@straker
Copy link
Contributor

straker commented Nov 13, 2019

Our license check seems to have stalled for some prs. An empty commit should retrigger it and fix the issue without needing a reapproval. git commit -m 'Empty commit to trigger CLA thing' --allow-empty

@WilcoFiers WilcoFiers merged commit 4635fef into develop Nov 14, 2019
@WilcoFiers WilcoFiers deleted the button-input-fix branch November 14, 2019 11:01
straker pushed a commit that referenced this pull request Dec 11, 2019
@WilcoFiers @straker
fix: input[role=button][value='correct'] should pass (#1897)
3aba02c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

@schne324 schne324 schne324 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilcoFiers @straker @schne324