Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(layout-table): deprecate layout-table rule and checks #1885

Merged
merged 1 commit into from Nov 7, 2019
Merged

feat(layout-table): deprecate layout-table rule and checks #1885

merged 1 commit into from Nov 7, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Nov 6, 2019 •
edited by WilcoFiers

The rule was written in a way that would never let it run. Deprecating it and its 3 checks which only this rule makes use of.

Closes issue: #1852

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner November 6, 2019 20:55
@straker straker merged commit d22cb30 into develop Nov 7, 2019
@straker straker deleted the deprecateLayoutTable branch November 7, 2019 18:21
@connorjclark connorjclark mentioned this pull request Nov 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@straker @WilcoFiers