feat(core/reporters/v1): Add failureSummary to incomplete results (#1972

)
dequelabs · Jan 13, 2020 · c88883d · c88883d
1 parent 8a62649
commit c88883d
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 6 deletions.
diff --git a/lib/core/reporters/v1.js b/lib/core/reporters/v1.js
@@ -9,11 +9,14 @@ axe.addReporter('v1', function(results, options, callback) {
 	}
 	var out = helpers.processAggregate(results, options);
 
-	out.violations.forEach(result =>
+	const addFailureSummaries = result => {
 		result.nodes.forEach(nodeResult => {
 			nodeResult.failureSummary = helpers.failureSummary(nodeResult);
-		})
-	);
+		});
+	};
+
+	out.incomplete.forEach(addFailureSummaries);
+	out.violations.forEach(addFailureSummaries);
 
 	callback({
 		...helpers.getEnvironmentData(),

diff --git a/test/core/reporters/v1.js b/test/core/reporters/v1.js
@@ -84,6 +84,34 @@ describe('reporters - v1', function() {
 					}
 				]
 			},
+			{
+				id: 'incomplete',
+				description: 'something yet more nifty',
+				tags: ['tag4'],
+				impact: 'monkeys',
+				result: 'failed',
+				passes: [],
+				violations: [],
+				incomplete: [
+					{
+						result: 'failed',
+						impact: 'monkeys',
+						none: [
+							{
+								data: 'foon',
+								impact: 'monkeys',
+								result: true
+							}
+						],
+						any: [],
+						all: [],
+						node: {
+							selector: ['foon'],
+							source: '<foon>telephone</foon>'
+						}
+					}
+				]
+			},
 			{
 				id: 'blinky',
 				description: 'something awesome',
@@ -232,16 +260,23 @@ describe('reporters - v1', function() {
 	});
 	it('should add the failure summary to the node data', function(done) {
 		var origFn = window.helpers.failureSummary;
-		window.helpers.failureSummary = function() {
-			return 'your foon is ringing';
+		window.helpers.failureSummary = function(nodeData) {
+			if (!nodeData || !nodeData.target) {
+				return;
+			}
+			return 'selector: ' + nodeData.target;
 		};
 		axe.run(optionsV1, function(err, results) {
 			assert.isNull(err);
 			assert.ok(results.violations[0].nodes);
 			assert.equal(results.violations[0].nodes.length, 1);
 			assert.equal(
 				results.violations[0].nodes[0].failureSummary,
-				'your foon is ringing'
+				'selector: q,r,pillock'
+			);
+			assert.equal(
+				results.incomplete[0].nodes[0].failureSummary,
+				'selector: foon'
 			);
 			window.helpers.failureSummary = origFn;
 			done();