fix(is-icon-ligature): ignore whitespace characters (#1908)

dequelabs · Nov 18, 2019 · 7d2b2a6 · 7d2b2a6
1 parent 9ae07fb
commit 7d2b2a6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/commons/text/is-icon-ligature.js b/lib/commons/text/is-icon-ligature.js
@@ -72,7 +72,7 @@ text.isIconLigature = function(
 	 * │ │█│█│█│█│█│█│█│█│█│█│█│█│█│ │
 	 * └─┴─┴─┴─┴─┴─┴─┴─┴─┴─┴─┴─┴─┴─┴─┘
 	 */
-	const nodeValue = textVNode.actualNode.nodeValue;
+	const nodeValue = textVNode.actualNode.nodeValue.trim();
 
 	// text with unicode or non-bmp letters cannot be ligature icons
 	if (

diff --git a/test/commons/text/is-icon-ligature.js b/test/commons/text/is-icon-ligature.js
@@ -121,6 +121,13 @@ describe('text.isIconLigature', function() {
 		}
 	);
 
+	(fontApiSupport ? it : it.skip)('should trim the string', function() {
+		var target = queryFixture(
+			'<div id="target" style="font-family: Roboto">  fflu shot  </div>'
+		);
+		assert.isFalse(isIconLigature(target.children[0]));
+	});
+
 	(fontApiSupport ? it : it.skip)(
 		'should return true for a font that has no character data',
 		function() {