Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call find only one time #18

Merged
merged 2 commits into from Jul 13, 2017
Merged

Call find only one time #18

merged 2 commits into from Jul 13, 2017

Conversation

delvedor
Copy link
Owner

As titled, there is a slightly improvements in the performances, any suggestion?

Before:

lookup static route x 21,752,581 ops/sec ±0.75% (90 runs sampled)
lookup dynamic route x 707,120 ops/sec ±1.14% (91 runs sampled)
lookup long static route x 2,894,137 ops/sec ±7.11% (86 runs sampled)
find static route x 31,506,022 ops/sec ±1.12% (87 runs sampled)
find dynamic route x 705,175 ops/sec ±0.85% (88 runs sampled)
find long static route x 3,994,827 ops/sec ±10.60% (83 runs sampled)

After:

lookup static route x 21,755,241 ops/sec ±0.83% (89 runs sampled)
lookup dynamic route x 717,386 ops/sec ±1.07% (90 runs sampled)
lookup long static route x 2,768,482 ops/sec ±6.72% (86 runs sampled)
find static route x 31,849,514 ops/sec ±0.79% (89 runs sampled)
find dynamic route x 737,994 ops/sec ±1.01% (87 runs sampled)
find long static route x 4,296,578 ops/sec ±10.29% (91 runs sampled)

@delvedor delvedor requested a review from mcollina July 13, 2017 13:27
@coveralls
Copy link

coveralls commented Jul 13, 2017

Coverage Status

Coverage decreased (-1.09%) to 97.561% when pulling 1477e85 on cache-find into a963dda on master.

Repository owner deleted a comment from coveralls Jul 13, 2017
Repository owner deleted a comment from coveralls Jul 13, 2017
@coveralls
Copy link

coveralls commented Jul 13, 2017

Coverage Status

Coverage decreased (-0.8%) to 97.832% when pulling 7253d83 on cache-find into a963dda on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 97.832% when pulling 7253d83 on cache-find into a963dda on master.

@coveralls
Copy link

coveralls commented Jul 13, 2017

Coverage Status

Coverage decreased (-0.8%) to 97.832% when pulling 7253d83 on cache-find into a963dda on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 97.832% when pulling 7253d83 on cache-find into a963dda on master.

@coveralls
Copy link

coveralls commented Jul 13, 2017

Coverage Status

Coverage decreased (-0.8%) to 97.826% when pulling 2133d0b on cache-find into a963dda on master.

@delvedor delvedor merged commit f58fba5 into master Jul 13, 2017
@delvedor delvedor deleted the cache-find branch July 13, 2017 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants