Skip to content

Commit

Permalink
fix(filter): replace is-subset with lodash.ismatch (#377)
Browse files Browse the repository at this point in the history
  • Loading branch information
pvdlg authored and bcoe committed Mar 25, 2019
1 parent 26fe91f commit fbcc92e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/conventional-commits-filter/index.js
@@ -1,6 +1,6 @@
'use strict'

var isSubset = require('is-subset')
var isMatch = require('lodash.ismatch')
var modifyValues = require('modify-values')

function modifyValue (val) {
Expand Down Expand Up @@ -36,7 +36,7 @@ function conventionalCommitsFilter (commits) {
ignores.some(function (ignoreCommit) {
var ignore = modifyValues(ignoreCommit.revert, modifyValue)

ignoreThis = isSubset(commit, ignore)
ignoreThis = isMatch(commit, ignore)

if (ignoreThis) {
remove.push(ignoreCommit.hash)
Expand Down
2 changes: 1 addition & 1 deletion packages/conventional-commits-filter/package.json
Expand Up @@ -28,7 +28,7 @@
"commits"
],
"dependencies": {
"is-subset": "^0.1.1",
"lodash.ismatch": "^4.4.0",
"modify-values": "^1.0.0"
},
"scripts": {
Expand Down

0 comments on commit fbcc92e

Please sign in to comment.