fix(cli): Make gz -a working again
#573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimthedev
approved these changes
Oct 1, 2018
|
@LinusU if looks good to you then feel free to squash and merge as all CI is passing! |
|
PS @thierrymichel thanks for the PR and your patience :) |
|
@jimthedev you're welcome. I hope it will address the issue. |
LinusU
reviewed
Oct 1, 2018
| @@ -6,7 +6,7 @@ export { isClean }; | |||
| * Asynchrounously determines if the staging area is clean | |||
| */ | |||
| function isClean (repoPath, done) { | |||
| exec('git diff --cached --name-only', { | |||
| exec('git diff --no-ext-diff --name-only && git diff --no-ext-diff --cached --name-only', { | |||
There was a problem hiding this comment.
Could git diff-index --quiet HEAD work? 🤔 That way we only have to execute git once.
There was a problem hiding this comment.
@LinusU The problem is that HEAD points to a commit/branch.
So, before your first commit, you will get a fatal: bad revision 'HEAD'.
There was a problem hiding this comment.
Ah, right, looks good then 👍 thanks for checking!
LinusU
approved these changes
Oct 3, 2018
|
ok, released in 3.0.2. Thanks for work @thierrymichel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #543