New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config loader): deal with config file charset #525
Conversation
make sure that config file charset is utf-8, or throw detail to notify.
make sure that config file charset is utf-8, or throw detail to notify.
I have resolved the conflict, maybe it is time to merge or close this pr. |
Thanks for your contribution! This looks good! |
@jimthedev can we revert this, or at least provide a hotfix release which includes |
This reverts commit c74eeb9.
@harryparkdotio Revert issued. |
It's my mistake. |
make sure that config file charset is utf-8, or throw detail to notify.
for #465 [Question] SyntaxError: Parsing JSON at for commitizen config failed