Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config loader): deal with config file charset #525

Merged
merged 5 commits into from Oct 19, 2018
Merged

fix(config loader): deal with config file charset #525

merged 5 commits into from Oct 19, 2018

Conversation

hxzhao527
Copy link
Contributor

make sure that config file charset is utf-8, or throw detail to notify.
for #465 [Question] SyntaxError: Parsing JSON at for commitizen config failed

hxzhao527 and others added 5 commits May 27, 2018 10:40
make sure that config file charset is utf-8, or throw detail to notify.
make sure that config file charset is utf-8, or throw detail to notify.
@hxzhao527
Copy link
Contributor Author

hxzhao527 commented Oct 19, 2018

I have resolved the conflict, maybe it is time to merge or close this pr.

@jimthedev jimthedev merged commit c74eeb9 into commitizen:master Oct 19, 2018
@jimthedev
Copy link
Member

Thanks for your contribution! This looks good!

@harryparkdotio
Copy link

@jimthedev can we revert this, or at least provide a hotfix release which includes is-utf8 as a dependency?

jimthedev added a commit that referenced this pull request Oct 20, 2018
jimthedev added a commit that referenced this pull request Oct 20, 2018
@jimthedev
Copy link
Member

@harryparkdotio Revert issued.

@hxzhao527
Copy link
Contributor Author

It's my mistake.
In my first version, I include the dependency isutf8(not is-utf8) manually. But ci failed me.:joy:
So I check my local node_modules folder, and found is-utf8.
I will add this dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants