Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Build only in python 3.12 #127

Merged
merged 1 commit into from May 15, 2024
Merged

ci: Build only in python 3.12 #127

merged 1 commit into from May 15, 2024

Conversation

giovanni-guidini
Copy link
Contributor

@giovanni-guidini giovanni-guidini commented Feb 19, 2024

context: codecov/engineering-team#874

Changing shared default image to use Python 3.12. We want to upgrade to the latest version.
Same move will be done in the worker and api repos as well.

Disabling ATS (not being used) and mutmut (doesn't work with 3.12 / not being used)

ps.: Obviously we need to update worker and api before using a version of shared that requires 3.12

UPDATE
Now that worker and api have been updated to python 3.12 we can update this one too

@codecov-staging
Copy link

codecov-staging bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (5c6de0f) to head (3c873ee).

❗ Current head 3c873ee differs from pull request most recent head 9992336. Consider uploading reports for the commit 9992336 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   89.32%   88.84%   -0.48%     
==========================================
  Files         107      104       -3     
  Lines        7026     6939      -87     
  Branches     1388     1396       +8     
==========================================
- Hits         6276     6165     -111     
- Misses        519      557      +38     
+ Partials      231      217      -14     
Flag Coverage Δ
python3.12 88.84% <ø> (?)
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c6de0f) 89.32% compared to head (3c873ee) 88.84%.

❗ Current head 3c873ee differs from pull request most recent head 9992336. Consider uploading reports for the commit 9992336 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   89.32%   88.84%   -0.48%     
==========================================
  Files         107      104       -3     
  Lines        7026     6939      -87     
  Branches     1388     1396       +8     
==========================================
- Hits         6276     6165     -111     
- Misses        519      557      +38     
+ Partials      231      217      -14     
Flag Coverage Δ
python3.12 88.84% <ø> (?)
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

Impacted file tree graph

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.24%. Comparing base (6f5b2ba) to head (51afadf).

❗ Current head 51afadf differs from pull request most recent head 2c735c2. Consider uploading reports for the commit 2c735c2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   89.50%   92.24%   +2.73%     
==========================================
  Files         324      116     -208     
  Lines       10395     7065    -3330     
  Branches     1813     1625     -188     
==========================================
- Hits         9304     6517    -2787     
+ Misses       1020      520     -500     
+ Partials       71       28      -43     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giovanni-guidini giovanni-guidini force-pushed the gio/build-only-3.12 branch 2 times, most recently from ba2e52e to 3c873ee Compare February 27, 2024 15:46
@giovanni-guidini
Copy link
Contributor Author

giovanni-guidini commented Feb 27, 2024

About the Run Mutations step.
It seems that mutmut runs (as in the mutants are executed).

The command that actually fails is the report generation (mutmut junitxml > /tmp/artifacts/mut.xml)... I tested locally (reproduced the same error). Also mutmut show all doesn't work (different error). Not sure why...

EDIT
ponyorm/pony#703

EDIT 2
Team decided to drop mutmut for now

joseph-sentry
joseph-sentry previously approved these changes Feb 29, 2024
Copy link
Contributor

@joseph-sentry joseph-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

just to make sure, this will mean we can't update the version of shared that we use to a version after this one, until the worker and api are both updated to use 3.12?

Do we think there will be issues with updating worker and api to 3.12 or should that be quick and straightforward?

@giovanni-guidini
Copy link
Contributor Author

lgtm

just to make sure, this will mean we can't update the version of shared that we use to a version after this one, until the worker and api are both updated to use 3.12?

Do we think there will be issues with updating worker and api to 3.12 or should that be quick and straightforward?

I hope it's quick and straightforward, but I'll not merge this until I do that move in case it isn't 😅

+ disable ATS (not using)
+ disable mutmut (doesn't work with python 3.12)
+ fix test assertion
@giovanni-guidini giovanni-guidini added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 3403b2c May 15, 2024
6 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/build-only-3.12 branch May 15, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants