New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Build only in python 3.12 #127
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 89.32% 88.84% -0.48%
==========================================
Files 107 104 -3
Lines 7026 6939 -87
Branches 1388 1396 +8
==========================================
- Hits 6276 6165 -111
- Misses 519 557 +38
+ Partials 231 217 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 89.32% 88.84% -0.48%
==========================================
Files 107 104 -3
Lines 7026 6939 -87
Branches 1388 1396 +8
==========================================
- Hits 6276 6165 -111
- Misses 519 557 +38
+ Partials 231 217 -14
Flags with carried forward coverage won't be shown. Click here to find out more. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 89.50% 92.24% +2.73%
==========================================
Files 324 116 -208
Lines 10395 7065 -3330
Branches 1813 1625 -188
==========================================
- Hits 9304 6517 -2787
+ Misses 1020 520 -500
+ Partials 71 28 -43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ba2e52e
to
3c873ee
Compare
About the The command that actually fails is the report generation ( EDIT EDIT 2 |
3c873ee
to
9992336
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
just to make sure, this will mean we can't update the version of shared that we use to a version after this one, until the worker
and api
are both updated to use 3.12
?
Do we think there will be issues with updating worker
and api
to 3.12
or should that be quick and straightforward?
I hope it's quick and straightforward, but I'll not merge this until I do that move in case it isn't 😅 |
9992336
to
51afadf
Compare
51afadf
to
2c735c2
Compare
+ disable ATS (not using) + disable mutmut (doesn't work with python 3.12) + fix test assertion
2c735c2
to
5739fce
Compare
context: codecov/engineering-team#874
Changing
shared
default image to use Python 3.12. We want to upgrade to the latest version.Same move will be done in the
worker
andapi
repos as well.Disabling ATS (not being used) and
mutmut
(doesn't work with 3.12 / not being used)ps.: Obviously we need to update worker and api before using a version of shared that requires 3.12
UPDATE
Now that worker and api have been updated to python 3.12 we can update this one too