ref: Remove repositoryDeprecated from api tests #2872

nicholas-codecov · 2024-05-10T14:35:34Z

Description

This PR updates the api util file to TS, as well as removing the repositoryDeprecated field in the api tests.

Notable Changes

Update api to TS
Update tests and remove repositoryDeprecated

codecov-qa · 2024-05-10T14:38:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (34bbe06) to head (0cb3b7b).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2872      +/-   ##
==========================================
- Coverage   98.48%   98.47%   -0.02%     
==========================================
  Files         879      879              
  Lines       12954    12954              
  Branches     3408     3451      +43     
==========================================
- Hits        12758    12756       -2     
- Misses        192      194       +2     
  Partials        4        4

Files	Coverage Δ
src/shared/api/api.ts	`94.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`54.54% <ø> (ø)`
Layouts	`97.26% <ø> (ø)`
Pages	`99.28% <ø> (ø)`
Services	`99.47% <ø> (ø)`
Shared	`99.68% <100.00%> (-0.16%)`	⬇️
UI	`94.53% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34bbe06...0cb3b7b. Read the comment docs.

codecov-public-qa · 2024-05-10T14:39:20Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (34bbe06) to head (0cb3b7b).

✅ All tests successful. No failed tests found ☺️

@@            Coverage Diff             @@
##             main    #2872      +/-   ##
==========================================
- Coverage   98.48%   98.47%   -0.02%     
==========================================
  Files         879      879              
  Lines       12954    12954              
  Branches     3469     3408      -61     
==========================================
- Hits        12758    12756       -2     
- Misses        192      194       +2     
  Partials        4        4

Files	Coverage Δ
src/shared/api/api.ts	`94.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`54.54% <ø> (ø)`
Layouts	`97.26% <ø> (ø)`
Pages	`99.28% <ø> (ø)`
Services	`99.47% <ø> (ø)`
Shared	`99.68% <100.00%> (-0.16%)`	⬇️
UI	`94.53% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34bbe06...0cb3b7b. Read the comment docs.

codecov-notifications · 2024-05-10T14:39:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #2872      +/-   ##
==========================================
- Coverage   98.48%   98.47%   -0.02%     
==========================================
  Files         879      879              
  Lines       12954    12954              
  Branches     3469     3409      -60     
==========================================
- Hits        12758    12756       -2     
- Misses        192      194       +2     
  Partials        4        4

Files	Coverage Δ
src/shared/api/api.ts	`94.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`54.54% <ø> (ø)`
Layouts	`97.26% <ø> (ø)`
Pages	`99.28% <ø> (ø)`
Services	`99.47% <ø> (ø)`
Shared	`99.68% <100.00%> (-0.16%)`	⬇️
UI	`94.53% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34bbe06...0cb3b7b. Read the comment docs.

codecov · 2024-05-10T14:39:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (34bbe06) to head (0cb3b7b).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #2872     +/-   ##
=======================================
- Coverage   98.49   98.47   -0.02     
=======================================
  Files        879     879             
  Lines      12954   12954             
  Branches    3451    3469     +18     
=======================================
- Hits       12758   12756      -2     
- Misses       192     194      +2     
  Partials       4       4

Files	Coverage Δ
src/shared/api/api.ts	`94.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`54.54% <ø> (ø)`
Layouts	`97.26% <ø> (ø)`
Pages	`99.28% <ø> (ø)`
Services	`99.47% <ø> (ø)`
Shared	`99.68% <100.00%> (-0.16%)`	⬇️
UI	`94.53% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34bbe06...0cb3b7b. Read the comment docs.

codecov-staging · 2024-05-10T14:40:38Z

Bundle Report

Changes will decrease total bundle size by 152 bytes ⬇️

Bundle name	Size	Change
gazebo-staging-array-push	6.61MB	152 bytes ⬇️

codecov · 2024-05-10T14:41:08Z

Bundle Report

Changes will decrease total bundle size by 152 bytes ⬇️

Bundle name	Size	Change
gazebo-production-array-push	6.61MB	152 bytes ⬇️

codecov-releaser · 2024-05-10T14:47:45Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit	Created	Cloud	Enterprise
`cbf3d2b`	Fri, 10 May 2024 14:47:45 GMT	Expired	Expired
`77b9685`	Tue, 14 May 2024 11:05:34 GMT	Expired	Expired
`cda5695`	Tue, 14 May 2024 13:05:18 GMT	Expired	Expired
`0cb3b7b`	Tue, 14 May 2024 14:50:05 GMT	Cloud	Enterprise

spalmurray-codecov · 2024-05-13T14:36:56Z

src/shared/api/api.test.ts

@@ -407,6 +433,7 @@ describe('when using a graphql mutation', () => {

    beforeAll(() => {
      const location = window.location
+      // @ts-expect-error - test magic


spalmurray-codecov · 2024-05-13T14:39:02Z

src/shared/api/api.ts

-function prefillMethod(method) {
-  return (config) =>
+function prefillMethod(method: string) {
+  return (config: any) =>


There's no type we can use here?

Config isn't typed yet ... and until we can ... I'd rather this just be any for the time being ... even tho it hurts every bone in my body.

Ok as long as you feel bad about it 😆

Feeling absolutely sick to my stomach about it

…api-test

nicholas-codecov added 3 commits May 10, 2024 09:58

move api to TS

c00803d

update api tests

550d378

update api tests to TS

cbf3d2b

spalmurray-codecov reviewed May 13, 2024

View reviewed changes

spalmurray-codecov approved these changes May 13, 2024

View reviewed changes

nicholas-codecov added 3 commits May 14, 2024 06:55

Merge branch 'main' into gh-eng-355-remove-repositoryDeprecated-from-…

77b9685

…api-test

Merge branch 'main' into gh-eng-355-remove-repositoryDeprecated-from-…

cda5695

…api-test

Merge branch 'main' into gh-eng-355-remove-repositoryDeprecated-from-…

0cb3b7b

…api-test

nicholas-codecov added this pull request to the merge queue May 14, 2024

Merged via the queue into main with commit ec8f628 May 14, 2024
56 of 60 checks passed

nicholas-codecov deleted the gh-eng-355-remove-repositoryDeprecated-from-api-test branch May 14, 2024 14:36

RulaKhaled pushed a commit that referenced this pull request May 16, 2024

ref: Remove repositoryDeprecated from api tests (#2872)

e10a75b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ref: Remove repositoryDeprecated from api tests #2872

ref: Remove repositoryDeprecated from api tests #2872

nicholas-codecov commented May 10, 2024

codecov-qa bot commented May 10, 2024 •

edited

codecov-public-qa bot commented May 10, 2024 •

edited

codecov-notifications bot commented May 10, 2024 •

edited

codecov bot commented May 10, 2024 •

edited

codecov-staging bot commented May 10, 2024 •

edited

codecov bot commented May 10, 2024 •

edited

codecov-releaser commented May 10, 2024 •

edited

spalmurray-codecov May 13, 2024

spalmurray-codecov May 13, 2024

nicholas-codecov May 13, 2024

spalmurray-codecov May 13, 2024

nicholas-codecov May 14, 2024

ref: Remove repositoryDeprecated from api tests #2872

ref: Remove repositoryDeprecated from api tests #2872

Conversation

nicholas-codecov commented May 10, 2024

Description

Notable Changes

codecov-qa bot commented May 10, 2024 • edited

Codecov Report

codecov-public-qa bot commented May 10, 2024 • edited

Codecov Report

codecov-notifications bot commented May 10, 2024 • edited

Codecov Report

codecov bot commented May 10, 2024 • edited

Codecov Report

codecov-staging bot commented May 10, 2024 • edited

Bundle Report

codecov bot commented May 10, 2024 • edited

Bundle Report

codecov-releaser commented May 10, 2024 • edited

✅ Deploy preview for gazebo ready!

spalmurray-codecov May 13, 2024

Choose a reason for hiding this comment

spalmurray-codecov May 13, 2024

Choose a reason for hiding this comment

nicholas-codecov May 13, 2024

Choose a reason for hiding this comment

spalmurray-codecov May 13, 2024

Choose a reason for hiding this comment

nicholas-codecov May 14, 2024

Choose a reason for hiding this comment

codecov-qa bot commented May 10, 2024 •

edited

codecov-public-qa bot commented May 10, 2024 •

edited

codecov-notifications bot commented May 10, 2024 •

edited

codecov bot commented May 10, 2024 •

edited

codecov-staging bot commented May 10, 2024 •

edited

codecov bot commented May 10, 2024 •

edited

codecov-releaser commented May 10, 2024 •

edited