Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Navigate on tos agreement success #2866

Merged
merged 3 commits into from May 14, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

Small tweak to how the useSaveTermsAgreement works so that after a successful mutation it redirects the user fixing the error described in codecov/engineering-team#1670

Closes codecov/engineering-team#1670

Notable Changes

  • Redirect to / when successful mutation
  • Update tests

Copy link

codecov-public-qa bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (cdedf62) to head (beba9f1).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2866   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         879      879           
  Lines       12951    12954    +3     
  Branches     3408     3469   +61     
=======================================
+ Hits        12755    12758    +3     
  Misses        192      192           
  Partials        4        4           
Files Coverage Δ
...rc/pages/TermsOfService/hooks/useTermsOfService.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdedf62...beba9f1. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2866   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         879      879           
  Lines       12951    12954    +3     
  Branches     3468     3469    +1     
=======================================
+ Hits        12755    12758    +3     
  Misses        192      192           
  Partials        4        4           
Files Coverage Δ
...rc/pages/TermsOfService/hooks/useTermsOfService.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdedf62...beba9f1. Read the comment docs.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.49%. Comparing base (cdedf62) to head (beba9f1).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2866   +/-   ##
=====================================
  Coverage   98.49   98.49           
=====================================
  Files        879     879           
  Lines      12951   12954    +3     
  Branches    3468    3408   -60     
=====================================
+ Hits       12755   12758    +3     
  Misses       192     192           
  Partials       4       4           
Files Coverage Δ
...rc/pages/TermsOfService/hooks/useTermsOfService.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdedf62...beba9f1. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented May 9, 2024

Bundle Report

Changes will increase total bundle size by 162 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.61MB 162 bytes ⬆️

@codecov-qa
Copy link

codecov-qa bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (cdedf62) to head (beba9f1).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2866   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         879      879           
  Lines       12951    12954    +3     
  Branches     3408     3474   +66     
=======================================
+ Hits        12755    12758    +3     
  Misses        192      192           
  Partials        4        4           
Files Coverage Δ
...rc/pages/TermsOfService/hooks/useTermsOfService.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdedf62...beba9f1. Read the comment docs.

Copy link

codecov bot commented May 9, 2024

Bundle Report

Changes will increase total bundle size by 162 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.61MB 162 bytes ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented May 9, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
2ba6739 Thu, 09 May 2024 12:12:31 GMT Expired Expired
beba9f1 Tue, 14 May 2024 14:19:29 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 34bbe06 May 14, 2024
60 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-1670-navigate-on-tos-agreement-succuss branch May 14, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continue action on sign up org selector not working
3 participants