-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add metrics to A and Button on click #2863
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some concerns here that these will break typesafety if converted to TS
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 1589 tests with View the full list of failed tests
|
1 similar comment
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 1589 tests with View the full list of failed tests
|
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 1589 tests with
View the full list of failed tests
|
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 1589 tests with View the full list of failed tests
|
Bundle ReportChanges will decrease total bundle size by 37.13kB ⬇️
|
Bundle ReportChanges will decrease total bundle size by 37.13kB ⬇️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
This PR aims to give us insight into click events occurring in the DOM for both the A and Button elements. We're using the existing Sentry metrics configuration to increment a metric on each click by hydrating the onClick event with this metric increment call.
Instead of doing each individually, this will give us a framework to get it for all A's and Buttons for free, and when our new event system is built out we can just swap out these for those instead.
Screenshots
Screen.Recording.2024-05-08.at.1.53.40.PM.mov
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.