fix: Hide sunburst on very large repos #2850

nicholas-codecov · 2024-05-07T12:41:16Z

Description

This PR contains a temp fix that hides the sunburst chart if there are more than 200,000 files in a given repo, until we have some more time to further investigate and come up with a solution for this.

Notable Changes

Grab file count in new useCoverageTabData hook
Hide Sunburst currently if file count is less than or equal to 200_000
Update/add in tests

codecov-qa · 2024-05-07T12:44:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (66f3413) to head (534b907).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2850      +/-   ##
==========================================
- Coverage   98.46%   98.46%   -0.01%     
==========================================
  Files         877      878       +1     
  Lines       12998    13033      +35     
  Branches     3420     3432      +12     
==========================================
+ Hits        12799    12833      +34     
- Misses        195      196       +1     
  Partials        4        4

Files	Coverage Δ
src/pages/RepoPage/CoverageTab/CoverageTab.jsx	`100.00% <100.00%> (ø)`
.../RepoPage/CoverageTab/hooks/useCoverageTabData.tsx	`100.00% <100.00%> (ø)`
...verageTab/subroute/CoverageChart/CoverageChart.jsx	`100.00% <100.00%> (ø)`
src/services/repo/useRepoCoverage.tsx	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`54.54% <ø> (ø)`
Layouts	`97.26% <ø> (ø)`
Pages	`99.27% <100.00%> (-0.02%)`	⬇️
Services	`99.48% <100.00%> (ø)`
Shared	`99.68% <ø> (ø)`
UI	`94.37% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f3413...534b907. Read the comment docs.

codecov · 2024-05-07T12:44:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (66f3413) to head (534b907).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #2850   +/-   ##
=====================================
  Coverage   98.46   98.46           
=====================================
  Files        877     878    +1     
  Lines      12998   13033   +35     
  Branches    3484    3432   -52     
=====================================
+ Hits       12799   12833   +34     
- Misses       195     196    +1     
  Partials       4       4

Files	Coverage Δ
src/pages/RepoPage/CoverageTab/CoverageTab.jsx	`100.00% <100.00%> (ø)`
.../RepoPage/CoverageTab/hooks/useCoverageTabData.tsx	`100.00% <100.00%> (ø)`
...verageTab/subroute/CoverageChart/CoverageChart.jsx	`100.00% <100.00%> (ø)`
src/services/repo/useRepoCoverage.tsx	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`54.54% <ø> (ø)`
Layouts	`97.26% <ø> (ø)`
Pages	`99.27% <100.00%> (-0.02%)`	⬇️
Services	`99.48% <100.00%> (ø)`
Shared	`99.68% <ø> (ø)`
UI	`94.37% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f3413...534b907. Read the comment docs.

codecov-public-qa · 2024-05-07T12:44:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (66f3413) to head (534b907).

✅ All tests successful. No failed tests found ☺️

@@            Coverage Diff             @@
##             main    #2850      +/-   ##
==========================================
- Coverage   98.46%   98.46%   -0.01%     
==========================================
  Files         877      878       +1     
  Lines       12998    13033      +35     
  Branches     3489     3496       +7     
==========================================
+ Hits        12799    12833      +34     
- Misses        195      196       +1     
  Partials        4        4

Files	Coverage Δ
src/pages/RepoPage/CoverageTab/CoverageTab.jsx	`100.00% <100.00%> (ø)`
.../RepoPage/CoverageTab/hooks/useCoverageTabData.tsx	`100.00% <100.00%> (ø)`
...verageTab/subroute/CoverageChart/CoverageChart.jsx	`100.00% <100.00%> (ø)`
src/services/repo/useRepoCoverage.tsx	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`54.54% <ø> (ø)`
Layouts	`97.26% <ø> (ø)`
Pages	`99.27% <100.00%> (-0.02%)`	⬇️
Services	`99.48% <100.00%> (ø)`
Shared	`99.68% <ø> (ø)`
UI	`94.37% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f3413...534b907. Read the comment docs.

codecov-staging · 2024-05-07T12:46:20Z

Bundle Report

Changes will increase total bundle size by 5.2kB ⬆️

Bundle name	Size	Change
gazebo-staging-array-push	6.61MB	5.2kB ⬆️

codecov · 2024-05-07T12:46:29Z

Bundle Report

Changes will increase total bundle size by 5.2kB ⬆️

Bundle name	Size	Change
gazebo-production-array-push	6.61MB	5.2kB ⬆️

codecov-releaser · 2024-05-07T12:51:17Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit	Created	Cloud	Enterprise
`a056dcf`	Tue, 07 May 2024 12:51:16 GMT	Expired	Expired
`87a5a8e`	Tue, 07 May 2024 19:33:59 GMT	Expired	Expired
`48eafc3`	Thu, 16 May 2024 16:15:51 GMT	Expired	Expired
`d1306dc`	Thu, 16 May 2024 16:55:51 GMT	Expired	Expired
`9d5cdc4`	Thu, 16 May 2024 17:09:43 GMT	Expired	Expired
`e28dde5`	Thu, 16 May 2024 18:02:08 GMT	Expired	Expired
`315e138`	Fri, 17 May 2024 10:45:02 GMT	Expired	Expired
`1fe004c`	Fri, 17 May 2024 13:21:21 GMT	Expired	Expired
`efb4c5d`	Fri, 17 May 2024 13:46:03 GMT	Expired	Expired
`7b81ba7`	Wed, 22 May 2024 10:51:28 GMT	Expired	Expired
`534b907`	Wed, 22 May 2024 14:53:36 GMT	Cloud	Enterprise

codecov-staging · 2024-05-16T16:00:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #2850      +/-   ##
==========================================
- Coverage   98.46%   98.46%   -0.01%     
==========================================
  Files         877      878       +1     
  Lines       12998    13033      +35     
  Branches     3484     3432      -52     
==========================================
+ Hits        12799    12833      +34     
- Misses        195      196       +1     
  Partials        4        4

Files	Coverage Δ
src/pages/RepoPage/CoverageTab/CoverageTab.jsx	`100.00% <100.00%> (ø)`
.../RepoPage/CoverageTab/hooks/useCoverageTabData.tsx	`100.00% <100.00%> (ø)`
...verageTab/subroute/CoverageChart/CoverageChart.jsx	`100.00% <100.00%> (ø)`
src/services/repo/useRepoCoverage.tsx	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`54.54% <ø> (ø)`
Layouts	`97.26% <ø> (ø)`
Pages	`99.27% <100.00%> (-0.02%)`	⬇️
Services	`99.48% <100.00%> (ø)`
Shared	`99.68% <ø> (ø)`
UI	`94.37% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f3413...534b907. Read the comment docs.

ajay-sentry · 2024-05-17T16:48:21Z

src/pages/RepoPage/CoverageTab/CoverageTab.jsx

+
+  let displaySunburst = false
+  const fileCount = data?.branch?.head?.totals?.fileCount
+  if (typeof fileCount === 'number' && fileCount <= 200_000) {


should this be 10_000? And maybe we can set to a const to avoid having magic numbers; like MAX_FILES_FOR_SUNBURST

ajay-sentry

looks good

ajay-sentry reviewed May 17, 2024

View reviewed changes

ajay-sentry approved these changes May 17, 2024

View reviewed changes

nicholas-codecov added 12 commits May 22, 2024 11:37

add in new useCoverageTabData hook

0121544

slight tweaks to CoverageChart styling

f92e77c

conditionally render sunburst on coverage tab

6c69c7a

bump to 100_000

d556e6a

bump to 200_000

27bad3d

add default return to useRepoCoverage

571eac4

adjust tests

4073548

extend the test timeout

02605bf

maybe give the sunburst actual data

1f47bb4

idk maybe waiting directly for the query client it'll be happier?

fcc6b5f

use ternary to be safe

3d0e661

mock out the sunburst cause it just is a pain

534b907

nicholas-codecov force-pushed the gh-int-472-hide-sunburst-on-very-large-repos branch from 7b81ba7 to 534b907 Compare May 22, 2024 14:41

nicholas-codecov added this pull request to the merge queue May 22, 2024

Merged via the queue into main with commit 6a5f330 May 22, 2024
57 of 60 checks passed

nicholas-codecov deleted the gh-int-472-hide-sunburst-on-very-large-repos branch May 22, 2024 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Hide sunburst on very large repos #2850

fix: Hide sunburst on very large repos #2850

nicholas-codecov commented May 7, 2024 •

edited

codecov-qa bot commented May 7, 2024 •

edited

codecov bot commented May 7, 2024 •

edited

codecov-public-qa bot commented May 7, 2024 •

edited

codecov-staging bot commented May 7, 2024 •

edited

codecov bot commented May 7, 2024 •

edited

codecov-releaser commented May 7, 2024 •

edited

codecov-staging bot commented May 16, 2024 •

edited by codecov-notifications bot

ajay-sentry May 17, 2024

ajay-sentry left a comment

fix: Hide sunburst on very large repos #2850

fix: Hide sunburst on very large repos #2850

Conversation

nicholas-codecov commented May 7, 2024 • edited

Description

Notable Changes

codecov-qa bot commented May 7, 2024 • edited

Codecov Report

codecov bot commented May 7, 2024 • edited

Codecov Report

codecov-public-qa bot commented May 7, 2024 • edited

Codecov Report

codecov-staging bot commented May 7, 2024 • edited

Bundle Report

codecov bot commented May 7, 2024 • edited

Bundle Report

codecov-releaser commented May 7, 2024 • edited

✅ Deploy preview for gazebo ready!

codecov-staging bot commented May 16, 2024 • edited by codecov-notifications bot

Codecov Report

ajay-sentry May 17, 2024

Choose a reason for hiding this comment

ajay-sentry left a comment

Choose a reason for hiding this comment

nicholas-codecov commented May 7, 2024 •

edited

codecov-qa bot commented May 7, 2024 •

edited

codecov bot commented May 7, 2024 •

edited

codecov-public-qa bot commented May 7, 2024 •

edited

codecov-staging bot commented May 7, 2024 •

edited

codecov bot commented May 7, 2024 •

edited

codecov-releaser commented May 7, 2024 •

edited

codecov-staging bot commented May 16, 2024 •

edited by codecov-notifications bot