Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump hono from 3.11.3 to 3.11.7 #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Dec 15, 2023

Bumps hono from 3.11.3 to 3.11.7.

Release notes

Sourced from hono's releases.

v3.11.7

Security Update

This release includes a security patch that fixes the vulnerability in TrieRouter.

If you are using the default preset or hono/quick, or specifying the router as TrieRouter, you must upgrade to this version 3.11.7 immediately.

How to upgrade

For Deno

Just increment the version specifier to v3.11.7.

import { Hono } from 'https://deno.land/x/hono@v3.11.7/mod.ts'
import { serveStatic } from 'https://deno.land/x/hono@v3.11.7/middleware.ts'

For Node.js

Upgrade the hono package via npm:

npm install hono
// OR
yarn add hono
// OR
pnpm up hono

You may not update the hono package with npm update, so please use npm install.

The vulnerability detail

The clients may override named path parameter values from previous requests if the application is using TrieRouter. So, there is a risk that a privileged user may use unintended parameters when deleting REST API resources.

TrieRouter is used either explicitly or when the application matches a pattern that is not supported by the default RegExpRouter.

The advisory: GHSA-f6gv-hh8j-q8vq

Our Approach to Security

If you discover such a vulnerability, please contact us immediately. We will respond immediately; we have enabled GitHub's private vulnerability reporting feature, so please use that.

https://github.com/honojs/hono/security/advisories

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 15, 2023
Copy link

@codecov codecov bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this commit are primarily updates to the 'hono' package versions in both the package.json and pnpm-lock.yaml files. No obvious issues are evident from this diff. However, it is key to ensure that these version updates do not introduce breaking changes. Dependency updates should also be followed by full regression testing to identify potential issues. Additionally, confirm whether the integrity SHA in the lock file was updated correctly after the package update.

@@ -5,7 +5,7 @@
},
"dependencies": {
"@hono/node-server": "^1.3.1",
"hono": "^3.11.2",
"hono": "^3.11.7",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'hono' package has been updated, ensure all necessary testing is done to confirm that this update doesn't introduce any breaking changes.

specifier: ^3.11.2
version: 3.11.3
specifier: ^3.11.7
version: 3.11.7
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version update should be accompanied by any necessary changes to your code that depend on this package. Make sure to verify this.

@@ -4463,8 +4463,8 @@ packages:
resolution: {integrity: sha512-EWGTfnTqAO2L/j5HZgoM/3z82L7necsJ0pO9Tp0X1wil3PDLrkypTBRgVO2ExehEEvUycejZD3FuRaXpZZc3kw==}
dev: true

/hono@3.11.3:
resolution: {integrity: sha512-MWYBcIS4dZJo9e/852Zwl+gqBiUSRknMOZ/MbW7kW8JiWixTJ58pzXVIeBq7jnvFq3AZ9uQ35QyVpzV05sdNFw==}
/hono@3.11.7:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the updated integrity SHA for the 'hono' package. It's important to confirm if this SHA the correct one corresponding to the new version of the package.

Copy link

@codecov codecov bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update seems to be mainly about increasing the version of the 'hono' dependency from 3.11.2 to 3.11.7 in both 'package.json' and 'pnpm-lock.yaml' files. The integrity hashes also have been updated correctly with the new version. Overall, these changes don't introduce any obvious issues.

@@ -5,7 +5,7 @@
},
"dependencies": {
"@hono/node-server": "^1.3.1",
"hono": "^3.11.2",
"hono": "^3.11.7",
Copy link

@codecov codecov bot Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'hono' package has been upgraded. We should ensure this new version has been sufficiently tested and does not introduce breaking changes in our application.

@@ -241,8 +241,8 @@ importers:
specifier: ^1.3.1
version: 1.3.1
hono:
specifier: ^3.11.2
version: 3.11.3
specifier: ^3.11.7
Copy link

@codecov codecov bot Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctly updated the version of 'hono' in the pnpm-lock file as well. This ensures version consistency across different parts of our codebase.

@@ -4463,8 +4463,8 @@ packages:
resolution: {integrity: sha512-EWGTfnTqAO2L/j5HZgoM/3z82L7necsJ0pO9Tp0X1wil3PDLrkypTBRgVO2ExehEEvUycejZD3FuRaXpZZc3kw==}
dev: true

/hono@3.11.3:
resolution: {integrity: sha512-MWYBcIS4dZJo9e/852Zwl+gqBiUSRknMOZ/MbW7kW8JiWixTJ58pzXVIeBq7jnvFq3AZ9uQ35QyVpzV05sdNFw==}
/hono@3.11.7:
Copy link

@codecov codecov bot Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated integrity hash is for the correct version and implies that the downloaded package has not been tampered with. This is essential for securing the codebase.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/hono-3.11.7 branch 2 times, most recently from 3b85153 to e5d08e2 Compare December 20, 2023 20:23
Copy link

@codecov codecov bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodecovAI submitted a new review for e5d08e2

@@ -4807,8 +4807,8 @@ packages:
resolution: {integrity: sha512-EWGTfnTqAO2L/j5HZgoM/3z82L7necsJ0pO9Tp0X1wil3PDLrkypTBRgVO2ExehEEvUycejZD3FuRaXpZZc3kw==}
dev: true

/hono@3.11.3:
resolution: {integrity: sha512-MWYBcIS4dZJo9e/852Zwl+gqBiUSRknMOZ/MbW7kW8JiWixTJ58pzXVIeBq7jnvFq3AZ9uQ35QyVpzV05sdNFw==}
Copy link

@codecov codecov bot Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integrity of the new version of 'hono' is updated as well. Let's check if it corresponds to the correct hash of the new hono package (v3.11.7) to verify the package integrity.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/hono-3.11.7 branch 2 times, most recently from 1b87255 to 67f4c88 Compare December 21, 2023 18:27
Copy link

@codecov codecov bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodecovAI submitted a new review for 67f4c88

specifier: ^3.11.2
version: 3.11.3
specifier: ^3.11.7
version: 3.11.7
Copy link

@codecov codecov bot Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'hono' version is now aligned with the package.json file. Good that consistency has been maintained between these files.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/hono-3.11.7 branch from 67f4c88 to 236df8b Compare December 21, 2023 18:47
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/hono-3.11.7 branch from 236df8b to 211670a Compare January 3, 2024 13:20
Copy link

@codecov codecov bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodecovAI submitted a new review for 211670a

/hono@3.11.3:
resolution: {integrity: sha512-MWYBcIS4dZJo9e/852Zwl+gqBiUSRknMOZ/MbW7kW8JiWixTJ58pzXVIeBq7jnvFq3AZ9uQ35QyVpzV05sdNFw==}
/hono@3.11.7:
resolution: {integrity: sha512-TcfAq7IdipF+9coxnuzYlSSBXbm9mTyWjjagLCv/2ampboNcKJdi+XCK5G48mHQtpI5+9Rj3J4FfcGgw9vzIww==}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node engine version specified here seems to be kept same as >=16.0.0. It is important to ensure that the updated hono package is fully compatible with this Node.js version.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/hono-3.11.7 branch 4 times, most recently from 172face to 939c8a1 Compare January 8, 2024 19:29
Bumps [hono](https://github.com/honojs/hono) from 3.11.3 to 3.11.7.
- [Release notes](https://github.com/honojs/hono/releases)
- [Commits](honojs/hono@v3.11.3...v3.11.7)

---
updated-dependencies:
- dependency-name: hono
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/hono-3.11.7 branch from 939c8a1 to deaab92 Compare January 10, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants