Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Google Cloud Build CI support #418

Merged
merged 1 commit into from May 14, 2024

Conversation

escarls
Copy link
Contributor

@escarls escarls commented Apr 16, 2024

Add Google Cloud Build CI detection and build meta-data extraction from the environment variables when they are mapped.

Google Cloud Build uses variable substitutions in the builds and not environment variables.

It is possible to map substitution variables to environment variables in the builds, but it has to be done manually.

For this CI adapter to work, these variables needs to be mapped:

env:
- '_PR_NUMBER=$_PR_NUMBER'
- 'BRANCH_NAME=$BRANCH_NAME'
- 'BUILD_ID=$BUILD_ID'
- 'COMMIT_SHA=$COMMIT_SHA'
- 'LOCATION=$LOCATION'
- 'PROJECT_ID=$PROJECT_ID'
- 'PROJECT_NUMBER=$PROJECT_NUMBER'
- 'REF_NAME=$REF_NAME'
- 'REPO_FULL_NAME=$REPO_FULL_NAME'
- 'TRIGGER_NAME=$TRIGGER_NAME'

@escarls escarls force-pushed the add-google-cloud-build-ci branch 2 times, most recently from 2ab9ece to 516333f Compare April 22, 2024 12:55
@escarls escarls marked this pull request as ready for review April 22, 2024 12:56
@escarls
Copy link
Contributor Author

escarls commented Apr 22, 2024

I know that the signature is missing, but it seemed to me that it's easier to work through the issues first, then sqash everything and then sign for final review.

@nikolaik
Copy link

This looks wonderful, would love to see this land!

@escarls escarls force-pushed the add-google-cloud-build-ci branch from bb945a6 to 5ebf1b1 Compare May 14, 2024 06:59
@escarls escarls force-pushed the add-google-cloud-build-ci branch from 5ebf1b1 to 693db87 Compare May 14, 2024 07:09
@escarls
Copy link
Contributor Author

escarls commented May 14, 2024

Anything missing from my side before a review @joseph-sentry ?

@joseph-sentry joseph-sentry merged commit 7432bad into codecov:main May 14, 2024
20 checks passed
@escarls escarls deleted the add-google-cloud-build-ci branch May 16, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants