Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dump GraphQL schema in pre-commit hook #185

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

scott-codecov
Copy link
Contributor

Purpose/Motivation

We'd like a clear way to determine when the GraphQL schema is changed. By making sure the full schema is part of every commit it will become clear in every commit what the schema diff is.

Links to relevant tickets

N/A

What does this PR do?

Adds a new Django management command to dump the GraphQL schema into a text file (graphql_api/schema.graphql). This command is run as part of the pre-commit.

Copy link
Contributor

@matt-codecov matt-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schema file is 20kb, git should handle that fine

@codecov-qa
Copy link

codecov-qa bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84a31da) 95.61% compared to head (ca27847) 95.61%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files         600      600           
  Lines       15223    15224    +1     
=======================================
+ Hits        14556    14557    +1     
  Misses        667      667           
Flag Coverage Δ
unit 95.61% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 95.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 23, 2023

Codecov Report

Merging #185 (ca27847) into main (84a31da) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files         600      600           
  Lines       15223    15224    +1     
=======================================
+ Hits        14556    14557    +1     
  Misses        667      667           
Flag Coverage Δ
unit 95.61% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 95.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov/commands/base.py 100.00% <100.00%> (ø)
codecov/commands/executor.py 100.00% <100.00%> (ø)
...commands/owner/interactors/save_terms_agreement.py 100.00% <100.00%> (ø)

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants