Initial integration with Umberto #428
Conversation
.gitignore
Outdated
| @@ -8,4 +8,6 @@ node_modules/** | |||
| build/** | |||
| coverage/** | |||
| packages/** | |||
| umberto-output/** | |||
There was a problem hiding this comment.
Can we keep this in build/docs/?
There was a problem hiding this comment.
Yes, I will change default output path to be build/docs/. Also any project can change the output path by creating a custom config file for hexo.
package.json
Outdated
| @@ -41,7 +41,8 @@ | |||
| "gulp": "^3.9.0", | |||
| "guppy-pre-commit": "^0.4.0", | |||
| "lerna": "^2.0.0-rc.1", | |||
| "mgit2": "^0.5.1" | |||
| "mgit2": "^0.5.1", | |||
| "umberto": "0.0.6" | |||
umberto.json
Outdated
| @@ -0,0 +1,80 @@ | |||
| { | |||
There was a problem hiding this comment.
I'm thinking... maybe it would be cleaner if this file was kept in docs/? There are already many files in the root dir of every package.
|
The commit message (the thing which starts with "Internal:...") should be in the PR body, not in the title. See other PRs for examples. |
gulpfile.js
Outdated
| } ); | ||
| } ); | ||
|
|
||
| gulp.task( 'umberto', () => { | ||
| return require( 'umberto' ) | ||
| .buildSingleProject( true ); |
There was a problem hiding this comment.
Maybe it's not a part of this PR, but we used to passing objects instead of flags as the objects are more explicit in such situations and easier to understand.
Consider this:
.buildSingleProject( { clean: true } );There was a problem hiding this comment.
Yep, I wanted to comment on this too. It's indeed not part of this PR though :D
m-turek
changed the title
…d gulp task. Updated package.json.
Reinmar
changed the title
|
OK, it seems that we're running into lerna/lerna#789. I disabled concurrency for now. It seems to slow down However, it made me think that perhaps we shouldn't install umberto by default. This slows down the whole process significantly as this entire tool is huuge. Maybe, we could have it as an optional dependency. I'd also move there ckeditor5-dev-env which is also pretty big. I need to think on that. |
Internal: Initial integration with Umberto. Example directory structure for documentation. Closes #427.