fix: update types for TypeScript v2.8

chrisguttandin · Mar 28, 2018 · 47a6536 · 47a6536
1 parent cf9488e
commit 47a6536
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 9 deletions.
diff --git a/src/audio-nodes/audio-destination-node.ts b/src/audio-nodes/audio-destination-node.ts
@@ -115,7 +115,11 @@ export class AudioDestinationNode implements IAudioDestinationNode {
         return this._audioNode.numberOfOutputs;
     }
 
-    public addEventListener (type: string, listener?: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions) {
+    public addEventListener (
+        type: string,
+        listener: EventListenerOrEventListenerObject | null = null,
+        options?: boolean | AddEventListenerOptions
+    ): void {
         return this._audioNode.addEventListener(type, listener, options);
     }
 
@@ -137,7 +141,11 @@ export class AudioDestinationNode implements IAudioDestinationNode {
         return this._audioNode.disconnect(destination);
     }
 
-    public removeEventListener (type: string, listener?: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions) {
+    public removeEventListener (
+        type: string,
+        listener: EventListenerOrEventListenerObject | null = null,
+        options?: EventListenerOptions | boolean
+    ): void {
         return this._audioNode.removeEventListener(type, listener, options);
     }
 

diff --git a/src/audio-nodes/audio-node.ts b/src/audio-nodes/audio-node.ts
@@ -110,7 +110,11 @@ export class AudioNode<T extends INativeAudioNodeFaker | TNativeAudioNode> exten
         return this._nativeNode.numberOfOutputs;
     }
 
-    public addEventListener (type: string, listener?: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions) {
+    public addEventListener (
+        type: string,
+        listener: EventListenerOrEventListenerObject | null = null,
+        options?: boolean | AddEventListenerOptions
+    ): void {
         return this._nativeNode.addEventListener(type, listener, options);
     }
 
@@ -269,7 +273,11 @@ export class AudioNode<T extends INativeAudioNodeFaker | TNativeAudioNode> exten
         return this._nativeNode.disconnect(nativeDestinationNode);
     }
 
-    public removeEventListener (type: string, listener?: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions) {
+    public removeEventListener (
+        type: string,
+        listener: EventListenerOrEventListenerObject | null = null,
+        options?: EventListenerOptions | boolean
+    ): void {
         return this._nativeNode.removeEventListener(type, listener, options);
     }
 

diff --git a/src/audio-param.ts b/src/audio-param.ts
@@ -75,7 +75,8 @@ export class AudioParam implements IAudioParam {
     }
 
     public setValueCurveAtTime (values: Float32Array, startTime: number, duration: number) {
-        this._nativeAudioParam.setValueCurveAtTime(values, startTime, duration);
+        // @todo TypeScript is expecting values to be an array of numbers.
+        this._nativeAudioParam.setValueCurveAtTime(<any> values, startTime, duration);
         this._audioParamRenderer.record({ duration, startTime, type: 'setValueCurve', values });
     }
 

diff --git a/src/event-target.ts b/src/event-target.ts
@@ -1,20 +1,28 @@
 export class EventTarget {
 
-    public addEventListener (type: string, listener?: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions) {
+    public addEventListener (
+        type: string,
+        listener: EventListenerOrEventListenerObject | null,
+        options?: boolean | AddEventListenerOptions
+    ): void {
         // @todo Implement the addEventListener() method.
         listener; // tslint:disable-line:no-unused-expression
         options; // tslint:disable-line:no-unused-expression
         type; // tslint:disable-line:no-unused-expression
     }
 
-    public dispatchEvent (evt: Event) {
+    public dispatchEvent (evt: Event): boolean {
         // @todo Implement the dispatchEvent() method.
         evt; // tslint:disable-line:no-unused-expression
 
         return false;
     }
 
-    public removeEventListener (type: string, listener?: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions) {
+    public removeEventListener (
+        type: string,
+        listener?: EventListenerOrEventListenerObject | null,
+        options?: EventListenerOptions | boolean
+    ): void {
         // @todo Implement the removeEventListener() method.
         listener; // tslint:disable-line:no-unused-expression
         options; // tslint:disable-line:no-unused-expression

diff --git a/src/renderers/audio-param.ts b/src/renderers/audio-param.ts
@@ -56,7 +56,8 @@ export class AudioParamRenderer implements IAudioParamRenderer {
             } else if (automation.type === 'setValueCurve') {
                 const { duration, startTime, values } = automation;
 
-                audioParam.setValueCurveAtTime(values, startTime, duration);
+                // @todo TypeScript is expecting values to be an array of numbers.
+                (<any> audioParam).setValueCurveAtTime(values, startTime, duration);
             } else {
                 throw new Error("Can't apply an unkown automation.");
             }