Simplify adding language chains with a check for the getter argument

chaijs · Mar 20, 2016 · 5223164 · 5223164
1 parent 56f6b50
commit 5223164
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/chai/core/assertions.js b/lib/chai/core/assertions.js
@@ -44,6 +44,8 @@ module.exports = function (chai, _) {
   , 'with', 'that', 'which', 'at'
   , 'of', 'same', 'but' ].forEach(function (chain) {
     Assertion.addProperty(chain, function () {
+      var newAssertion = new Assertion();
+      _.transferFlags(this, newAssertion);
       return this;
     });
   });

diff --git a/lib/chai/utils/addProperty.js b/lib/chai/utils/addProperty.js
@@ -35,6 +35,8 @@ var transferFlags = require('./transferFlags');
  */
 
 module.exports = function (ctx, name, getter) {
+  getter = getter === undefined ? new Function() : getter;
+
   Object.defineProperty(ctx, name,
     { get: function addProperty() {
         var old_ssfi = flag(this, 'ssfi');