Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable closing after "keepOpen()" has been called #217

Merged
merged 1 commit into from Jul 24, 2018

Conversation

martypdx
Copy link
Contributor

@martypdx martypdx commented Jul 16, 2018

Test and changes to request to allow .keepOpen() request to actually close, fixes #189.

FYI Side Note - I had to disable posttest script during local development as it causes npm test to fail (I have no token) with:

> if [ -z "$COVERALLS_REPO_TOKEN" ]; then cat coverage/lcov.info | coveralls; fi

/Users/marty/dev/chai-http/node_modules/coveralls/bin/coveralls.js:18
        throw err;
        ^
Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true}

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I approve of this. Someone else from @chaijs/chai-http should merge!

@JamesMessinger
Copy link
Member

LGTM

@JamesMessinger JamesMessinger merged commit 1af976d into chaijs:master Jul 24, 2018
@austince austince mentioned this pull request Aug 3, 2018
JamesMessinger added a commit that referenced this pull request Aug 14, 2018
4.1.0

Changes included:

- #219
- #217

Fixes:

- #218
- #189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server not closing
3 participants