1.14.134

[ci skip]

ccxt.js

@@ -37,7 +37,7 @@ const Exchange  = require ('./js/base/Exchange')
 //-----------------------------------------------------------------------------
 // this is updated by vss.js when building
 
-const version = '1.14.133'
+const version = '1.14.134'
 
 Exchange.ccxtVersion = version
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "1.14.133",
+  "version": "1.14.134",
   "description": "A JavaScript / Python / PHP cryptocurrency trading library with support for 100+ exchanges",
   "main": "./ccxt.js",
   "unpkg": "build/ccxt.browser.js",

php/Exchange.php

@@ -30,7 +30,7 @@
 
 namespace ccxt;
 
-$version = '1.14.133';
+$version = '1.14.134';
 
 // rounding mode
 const TRUNCATE = 0;

php/kraken.php

@@ -629,8 +629,13 @@ public function create_order ($symbol, $type, $side, $amount, $price = null, $pa
             'ordertype' => $type,
             'volume' => $this->amount_to_precision($symbol, $amount),
         );
-        if ($type === 'limit')
+        $priceIsDefined = ($price !== null);
+        $marketOrder = ($type === 'market');
+        $limitOrder = ($type === 'limit');
+        $shouldIncludePrice = $limitOrder || (!$marketOrder && $priceIsDefined);
+        if ($shouldIncludePrice) {
             $order['price'] = $this->price_to_precision($symbol, $price);
+        }
         $response = $this->privatePostAddOrder (array_merge ($order, $params));
         $id = $this->safe_value($response['result'], 'txid');
         if ($id !== null) {

python/ccxt/__init__.py

@@ -22,7 +22,7 @@
 
 # ----------------------------------------------------------------------------
 
-__version__ = '1.14.133'
+__version__ = '1.14.134'
 
 # ----------------------------------------------------------------------------
 

python/ccxt/async/__init__.py

@@ -4,7 +4,7 @@
 
 # -----------------------------------------------------------------------------
 
-__version__ = '1.14.133'
+__version__ = '1.14.134'
 
 # -----------------------------------------------------------------------------
 

python/ccxt/async/base/exchange.py

@@ -2,7 +2,7 @@
 
 # -----------------------------------------------------------------------------
 
-__version__ = '1.14.133'
+__version__ = '1.14.134'
 
 # -----------------------------------------------------------------------------
 

python/ccxt/async/kraken.py

@@ -615,7 +615,11 @@ async def create_order(self, symbol, type, side, amount, price=None, params={}):
             'ordertype': type,
             'volume': self.amount_to_precision(symbol, amount),
         }
-        if type == 'limit':
+        priceIsDefined = (price is not None)
+        marketOrder = (type == 'market')
+        limitOrder = (type == 'limit')
+        shouldIncludePrice = limitOrder or (not marketOrder and priceIsDefined)
+        if shouldIncludePrice:
             order['price'] = self.price_to_precision(symbol, price)
         response = await self.privatePostAddOrder(self.extend(order, params))
         id = self.safe_value(response['result'], 'txid')

python/ccxt/base/exchange.py

@@ -4,7 +4,7 @@
 
 # -----------------------------------------------------------------------------
 
-__version__ = '1.14.133'
+__version__ = '1.14.134'
 
 # -----------------------------------------------------------------------------
 

python/ccxt/kraken.py

@@ -615,7 +615,11 @@ def create_order(self, symbol, type, side, amount, price=None, params={}):
             'ordertype': type,
             'volume': self.amount_to_precision(symbol, amount),
         }
-        if type == 'limit':
+        priceIsDefined = (price is not None)
+        marketOrder = (type == 'market')
+        limitOrder = (type == 'limit')
+        shouldIncludePrice = limitOrder or (not marketOrder and priceIsDefined)
+        if shouldIncludePrice:
             order['price'] = self.price_to_precision(symbol, price)
         response = self.privatePostAddOrder(self.extend(order, params))
         id = self.safe_value(response['result'], 'txid')