Merge pull request #114 from Aosanders/master

splice fix training
canjs · Jun 2, 2018 · 221c5f4 · 221c5f4
2 parents c648990 + 9ebeadf
commit 221c5f4
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 0 deletions.
diff --git a/reflections/get-set/get-set-test.js b/reflections/get-set/get-set-test.js
@@ -90,3 +90,18 @@ QUnit.test("setValue", function(){
 
 	QUnit.deepEqual(obj, {value: 2}, "can.setValue");
 });
+
+QUnit.test("splice", function(){
+	var arr = ["a","b"];
+
+	getSetReflections.splice(arr, 0, 1);
+
+	QUnit.deepEqual(arr, ["b"], "removes item with no additions");
+
+	arr = ["a","b"];
+
+	getSetReflections.splice(arr, 0, 1, ["c", "d"]);
+
+	QUnit.deepEqual(arr, ["c","d","b"], "removes item with no additions");
+
+});
diff --git a/reflections/get-set/get-set.js b/reflections/get-set/get-set.js
@@ -191,6 +191,10 @@ var reflections = {
 			howMany = removing;
 		}
 
+		if(arguments.length <= 3){
+			adding = [];
+		}
+
 		var splice = obj[canSymbol.for("can.splice")];
 		if(splice) {
 			return splice.call(obj, index, howMany, adding);

diff --git a/reflections/type/type-test.js b/reflections/type/type-test.js
@@ -82,6 +82,8 @@ QUnit.test("isMapLike", function(){
 QUnit.test("isMoreListLikeThanMapLike", function(){
 	QUnit.equal(typeReflections.isMoreListLikeThanMapLike({}), false, "Object");
 	QUnit.equal(typeReflections.isMoreListLikeThanMapLike([]), true, "Array");
+	QUnit.equal(typeReflections.isMoreListLikeThanMapLike(undefined), "undefined", "undefined");
+	QUnit.equal(typeReflections.isMoreListLikeThanMapLike(null), "undefined", "null");
 });
 
 QUnit.test("isObservableLike", function(){

diff --git a/reflections/type/type.js b/reflections/type/type.js
@@ -453,6 +453,9 @@ module.exports = {
 		if(obj instanceof Array) {
 			return true;
 		}
+		if(obj === undefined || obj === null) {
+			return "undefined";
+		}
 		var value = obj[canSymbol.for("can.isMoreListLikeThanMapLike")];
 		if(value !== undefined) {
 			return value;