fix DataView on node 0.10

browserify · May 1, 2019 · 1ef3b53 · 1ef3b53
1 parent 5abeabe
commit 1ef3b53
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/support/types.js b/support/types.js
@@ -309,7 +309,7 @@ function isDataViewToString(value) {
 isDataViewToString.working = (
   typeof ArrayBuffer !== 'undefined' &&
   typeof DataView !== 'undefined' &&
-  isDataViewToString(new DataView(new ArrayBuffer()))
+  isDataViewToString(new DataView(new ArrayBuffer(1), 0, 1))
 );
 function isDataView(value) {
   if (typeof DataView === 'undefined') {

diff --git a/test/node/types.js b/test/node/types.js
@@ -82,7 +82,7 @@ for (var _i = 0, _arr = [
       value: 'foo'
     });
   }, 'isUint8Array'],
-  [function () { return new DataView(new ArrayBuffer(1)); }, 'isDataView'],
+  [function () { return new DataView(new ArrayBuffer(1), 0, 1); }, 'isDataView'],
   [function () { return new SharedArrayBuffer(); }, 'isSharedArrayBuffer'],
   // [ new Proxy({}, {}), 'isProxy' ],
   [function () { return new WebAssembly.Module(wasmBuffer); }, 'isWebAssemblyCompiledModule']
@@ -170,7 +170,7 @@ if (SymbolToStringTagSupported) {
   var arrayBuffer = function arrayBuffer() { return new ArrayBuffer(1); };
 
   var buffer = function buffer() { return Buffer.from(arrayBuffer()); };
-  var dataView = function dataView() { return new DataView(arrayBuffer()); };
+  var dataView = function dataView() { return new DataView(arrayBuffer(), 0, 1); };
   var uint8Array = function uint8Array() { return new Uint8Array(arrayBuffer()); };
   var uint8ClampedArray = function uint8ClampedArray() { return new Uint8ClampedArray(arrayBuffer()); };
   var uint16Array = function uint16Array() { return new Uint16Array(arrayBuffer()); };
@@ -208,7 +208,7 @@ if (SymbolToStringTagSupported) {
   var fakeBigUint64Array = function fakeBigUint64Array() { return Object.create(BigUint64Array.prototype); };
 
   var stealthyDataView = function stealthyDataView() {
-    return Object.setPrototypeOf(new DataView(arrayBuffer()), Uint8Array.prototype);
+    return Object.setPrototypeOf(new DataView(arrayBuffer(), 0, 1), Uint8Array.prototype);
   };
   var stealthyUint8Array = function stealthyUint8Array() {
     return Object.setPrototypeOf(new Uint8Array(arrayBuffer()), ArrayBuffer.prototype);