Skip to content

Commit

Permalink
Merge pull request #1794 from ljharb/restore_old_node
Browse files Browse the repository at this point in the history
Restore support down to node 0.8
  • Loading branch information
bcomnes committed Jan 10, 2018
2 parents d85aa76 + a522c43 commit c668b99
Show file tree
Hide file tree
Showing 7 changed files with 71 additions and 51 deletions.
14 changes: 14 additions & 0 deletions .travis.yml
Expand Up @@ -4,3 +4,17 @@ node_js:
- "8"
- "6"
- "4"
- "iojs"
- "0.12"
- "0.10"
- "0.8"
- "0.6"
before_install:
- 'nvm install-latest-npm'
install:
- 'if [ "${TRAVIS_NODE_VERSION}" = "0.6" ] || [ "${TRAVIS_NODE_VERSION}" = "0.9" ]; then nvm install --latest-npm 0.8 && npm install && nvm use "${TRAVIS_NODE_VERSION}"; else npm install; fi;'
sudo: false
matrix:
fast_finish: true
allow_failures:
- node_js: "0.6"
72 changes: 28 additions & 44 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions package.json
Expand Up @@ -11,7 +11,7 @@
"url": "http://github.com/browserify/browserify.git"
},
"engines": {
"node": ">= 4.0"
"node": ">= 0.8"
},
"keywords": [
"browser",
Expand Down Expand Up @@ -46,7 +46,7 @@
"inherits": "~2.0.1",
"insert-module-globals": "^7.0.0",
"labeled-stream-splicer": "^2.0.0",
"module-deps": "^5.0.0",
"module-deps": "^5.0.1",
"os-browserify": "~0.3.0",
"parents": "^1.0.1",
"path-browserify": "~0.0.0",
Expand Down Expand Up @@ -76,7 +76,9 @@
"browser-unpack": "^1.1.1",
"coffee-script": "~1.10.0",
"coffeeify": "~1.1.0",
"has-template-literals": "^1.0.0",
"isstream": "^0.1.2",
"make-generator-function": "^1.1.0",
"seq": "0.3.5",
"tap": "^10.7.2",
"temp": "^0.8.1",
Expand Down
20 changes: 19 additions & 1 deletion test/quotes.js
Expand Up @@ -2,10 +2,28 @@ var browserify = require('../');
var vm = require('vm');
var test = require('tap').test;

var hasTemplateLiterals = require('has-template-literals')();

test('quotes', function (t) {
t.plan(3);
t.plan(2);

var b = browserify(__dirname + '/quotes/main.js');
b.bundle(function (err, src) {
var c = {
done : function (single, double) {
t.equal(single, 'success', 'single quotes');
t.equal(double, 'success', 'double quotes');
t.end();
}
};
vm.runInNewContext(src, c);
});
});

test('interpolation literals', { skip: !hasTemplateLiterals }, function (t) {
t.plan(3);

var b = browserify(__dirname + '/quotes/backtick.js');
b.bundle(function (err, src) {
var c = {
done : function (single, double, backtick) {
Expand Down
1 change: 1 addition & 0 deletions test/quotes/backtick.js
@@ -0,0 +1 @@
done(require('./one.js'), require("./two.js"), require(`./three.js`));
2 changes: 1 addition & 1 deletion test/quotes/main.js
@@ -1 +1 @@
done(require('./one.js'), require("./two.js"), require(`./three.js`));
done(require('./one.js'), require("./two.js"));
7 changes: 4 additions & 3 deletions test/yield.js
@@ -1,17 +1,18 @@
var browserify = require('../');
var test = require('tap').test;
var vm = require('vm');
var generatorFunction = require('make-generator-function');

test('yield', function (t) {
test('yield', { skip: !generatorFunction }, function (t) {
t.plan(6);
var b = browserify(__dirname + '/yield/main.js');

b.bundle(function (err, src) {
t.error(err);
var c = { console: { log: log } };
var index = 0;
vm.runInNewContext(src, c);

function log (msg) {
t.equal(index++, msg);
}
Expand Down

0 comments on commit c668b99

Please sign in to comment.