Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder the user, password, host, port and database appearances for uniformity. #3207

Merged
merged 1 commit into from May 10, 2024

Conversation

juangpc
Copy link
Contributor

@juangpc juangpc commented May 10, 2024

Hi,
Trying to add uniformity to the use of the keys (user, password, host, port and database) in the code and docs.
I see the use of fields scattered in code and in documentation, in many different orders. Figured it could help for clarity to try to have a similar as possible order. Makes it easier to see if you're forgetting one of them, identify changes, etc...

New to pg. Figured could be helpful. Thanks for a great package.

Fun fact (Had to check it out).
When you have 3 terms -> ternary.
when you have 4 terms -> quaternary. (ref.stack exchange discussion)

@brianc
Copy link
Owner

brianc commented May 10, 2024

Hi! Thanks for the house keeping PR! Things like this add up overtime to a generally better code base & I appreciate it! 😄

@brianc brianc merged commit 0096856 into brianc:master May 10, 2024
7 checks passed
@juangpc juangpc deleted the new_client_docs branch May 14, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants