Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change hasOne's doc #1890

Merged
merged 2 commits into from Sep 13, 2018
Merged

change hasOne's doc #1890

merged 2 commits into from Sep 13, 2018

Conversation

eerenyuan
Copy link
Contributor

Introduction

a possible typo in model.hasOne's doc

ricardograca
ricardograca approved these changes Sep 13, 2018
View reviewed changes
Copy link
Member

@ricardograca ricardograca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'll merge this as is, but if you could also update the hasMany document which has a similar mistake that would be great. I guess these were just copied over from belongsTo.

@ricardograca ricardograca added this to To Do in Version 0.14.0 via automation Sep 13, 2018
@eerenyuan
Copy link
Contributor Author

I made that change in my fork. But It seems I messed things up: that commitment was combined with the other pull request which I later closed. and I don't know how to make that change in this one....

@ricardograca
Copy link
Member

You can push more commits to the eerenyuan:patch-1 branch to update this PR.

@eerenyuan
Copy link
Contributor Author

done:)

@ricardograca ricardograca merged commit b6abda9 into bookshelf:master Sep 13, 2018
Version 0.14.0 automation moved this from To Do to Done Sep 13, 2018
@ricardograca
Copy link
Member

Many thanks!

@snyk-bot snyk-bot mentioned this pull request May 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardograca ricardograca ricardograca approved these changes

Assignees
No one assigned
Labels
docs
Projects
No open projects
Version 0.14.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eerenyuan @ricardograca