Fix once method not passing correct arguments to callback #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This fixes the
.oncemethod not passing the correct arguments to its callback. This bug is not present in any released versions and is only found in commits after 2ebd1af.Proposed solution
This bug was introduced in the previous PR due to an incorrect conversion of the previous code. Since fat arrow functions don't have their own
argumentsand the use of the rest operator is not possible on Node 4, the changes meant that the arguments being passed were the wrong ones.Also fixes one other test case that wasn't returning a Promise as it should, and adds a new
Event#trigger()unit test for good measure.