Fix timestamp() setting a key named "null" in some cases

[ricardograca]

• Previous PRs: Clean up automatic timestamps feature #1798

Introduction

The previous PR introduced a bug where a model could end up with a key named "null" if the user specified a custom hasTimestamps value that included a literal null as the second key name. This would lead to a SQL error complaining about a nonexistent column named "null" or "undefined".

Proposed solution

This checks if a updatedAt key exists first before attempting any other comparisons. The problem was in the first condition that would incorrectly return true if the key hadn't been set, even though it should only be checking if it had been set by the user.

[amaranadh-wal]

If we give only created_at attribute in the array it is taking undefined in the insert query instead of updated_at.

For example

export default homeBookshelf.Model.extend({
  tableName: 'notifications',
  hasTimestamps: ['created_at'], ...

For above model declaration the query is going like

insert into 'notifications' ('created_at', 'initiator_id', 'initiator_type', 'notification_group_id', 'undefined', 'user_id') values ('2018-06-14 15:41:18.019', 333, 'user', 187, '2018-06-14 15:41:18.019', DEFAULT)

If we give like

export default homeBookshelf.Model.extend({
  tableName: 'notifications',
  hasTimestamps: ['created_at',null],

Then the query is going like

insert into notifications ('created_at', 'initiator_id', 'initiator_type', 'notification_group_id', 'null', 'user_id') values ('2018-06-14 15:40:41.754', 322, 'user', 180, '2018-06-14 15:40:41.754', DEFAULT)

So, I have given false value for the > hasTimestamps then it is working.

[ricardograca]

Have you tried the code that is in this change or are you referring only to the published version 0.13.3?

[amaranadh-wal]

I am referring the published version bookshelf@0.13.3 only.

…

On Thu, Jun 14, 2018 at 4:38 PM, Ricardo Graça ***@***.***> wrote: Have you tried the code that is in this change or are you referring only to the published version 0.13.3? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1820 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AlchsrdzscGFrlb-xiHeclrQQbuuKeiAks5t8kQzgaJpZM4Tfmw6> .

-- Thanks & Regards,Meda AmaranadhSr.Software Development Engineer ------------------------------ westagilelabs.com LinkedIn <https://www.linkedin.com/in/thisisamar/>

[ricardograca]

This PR you're commenting on fixes that then.