Add row-level locking options #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This only works inside a transaction and seems to make no effect on MySQL where it will always lock even without the option. - There's also no support for this feature on SQLite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Follow-up to the previous implementation on the linked PR.
Motivation and Proposed solution
This adds tests and uses a slightly different implementation that is less repetitive and more easily expandable if needed.
Closes #516.
Current PR Issues
Tests aren't very exhaustive.
There's also no check to see if the lock options are being applied to a
selectstatement, but it's possible that Knex already takes care of this. In any case this is an advanced feature, so users that want it should know what they're doing.