Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up automatic timestamps feature #1798

Merged
merged 7 commits into from
Mar 25, 2018
Merged

Clean up automatic timestamps feature #1798

merged 7 commits into from
Mar 25, 2018

Commits on Mar 24, 2018

  1. Move Model#timestamp tests to the correct file 

    - These are actually unit tests, not integration.
    @ricardograca
    ricardograca committed Mar 24, 2018
    Configuration menu
    Copy the full SHA
    5686f2a View commit details
    Browse the repository at this point in the history

  2. Refactor timestamp tests

    @ricardograca
    ricardograca committed Mar 24, 2018
    Configuration menu
    Copy the full SHA
    4a06cd3 View commit details
    Browse the repository at this point in the history

  3. Add more tests to verify user supplied timestamps

    @ricardograca
    ricardograca committed Mar 24, 2018
    Configuration menu
    Copy the full SHA
    ae80dcf View commit details
    Browse the repository at this point in the history

  4. Fix automatic timestamps 

    - This fixes the automatic timestamp handling to behave like the Rails'
ActiveRecord counterpart.

- The updated_at attribute now isn't automatically updated if the model
hasn't changed.

- User supplied values of the created_at and updated_at attributes
always override the automatic values.
    @ricardograca
    ricardograca committed Mar 24, 2018
    Configuration menu
    Copy the full SHA
    0e7c318 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2018

  1. Update timestamps related documentation

    @ricardograca
    ricardograca committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    e8f5806 View commit details
    Browse the repository at this point in the history

  2. Remove Model.save date option test 

    - This feature has been deprecated in favor of setting the value of
timestamps directly on the model's attributes.
    @ricardograca
    ricardograca committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    cf11ffd View commit details
    Browse the repository at this point in the history

  3. Update timestamp test description

    @ricardograca
    ricardograca committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    d37eb47 View commit details
    Browse the repository at this point in the history