parse/format example

in parse, when it doesn't response a tag column (e.g. only id is responsed), ||'[]' will add will set tags to empty, which in my opinion is not true. Similarly, in format, if tags is not provides, it should not be updated.
bookshelf · Sep 19, 2018 · 2510355 · 2510355
1 parent 30ffc63
commit 2510355
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/tutorials/parse-and-format.md b/tutorials/parse-and-format.md
@@ -9,11 +9,13 @@ methods:
 Book = bookshelf.Model.extend({
   tableName: 'books',
   parse: function(response) {
-    response.tags = JSON.parse(response.tags || '[]');
+    if(response.tags)
+      response.tags = JSON.parse(response.tags);
     return response;
   },
   format: function(attributes) {
-    attributes.tags = JSON.stringify(attributes.tags || []);
+    if(attributes.tags)
+      attributes.tags = JSON.stringify(attributes.tags);
     return attributes;
   }
 });