renderToNodeStream -> renderToStream #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renderToNodeStream -> renderToStream
Fix renderToStream API call
|
Thanks! Glad you enjoyed it! 馃槂 So yeah, I had the original code you've just suggested, and then stumbled upon the commit you linked to. I figured it would be better to have the newest API, but you're right that the latest beta still has the old API. I should've just mentioned the change, but totally forgot! I think I'll leave it, but thanks for the call out! How'd the streaming turn out for you? |
|
@benmvp Got it working great, thanks! https://github.com/magicmark/personal-website-v2/blob/master/src/server.js#L39 馃憣 Fun to play around with. Interesting to see how we'll take advantage of this in production. |
|
Niiiiiice! BTW - I'm still super impressed that you were able to find this repo and make the fix. 馃槈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for the awesome talk at React Rally! 馃憦 馃槂
I was playing around with the new version of
react-dom(16.0.0-beta.5) to try and use the streaming API, following your example.Although the API used will be correct soon (facebook/react#10425), the current
@nextrelease (16.0.0-beta.5) appears to still use the old API.(Probably not be worth merging if it's being released soon - just mentioning it in case someone else runs into this for now.)
Thanks again!