Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chocolatey powershellgallery resharper] Fix "not found" error for chocolatey badge #10060

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

t1m0thyj
Copy link
Contributor

@t1m0thyj t1m0thyj commented Apr 2, 2024

Fixes #10045

The "got" package encodes spaces in searchParams as + (see sindresorhus/got#1113) but the Chocolatey API requires spaces to be encoded as %20 instead.

I have tested that npm run test:services -- --only=chocolatey,nuget passes with these changes.

Example of failing query:
https://community.chocolatey.org/api/v2/Packages()?%24filter=Id+eq+%27windynamicdesktop%27+and+IsLatestVersion+eq+true

Example of working query:
https://community.chocolatey.org/api/v2/Packages()?%24filter=Id%20eq%20%27windynamicdesktop%27%20and%20IsLatestVersion%20eq%20true

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @t1m0thyj!

Generated by 🚫 dangerJS against 2464823

@chris48s chris48s changed the title [Chocolatey Nuget] Fix "not found" error for chocolatey badge [chocolatey powershellgallery resharper] Fix "not found" error for chocolatey badge Apr 2, 2024
@chris48s
Copy link
Member

chris48s commented Apr 2, 2024

Hi. Thanks for having a look at this - good catch.

The nuget badges themselves actually use the nuget-v3-service-family helpers.

The nuget-v2-service-family helpers are used by chocolatey, powershellgallery and resharper.

I did some testing locally and it seems this change doesn't impact the behaviour of powershellgallery or resharper. Great that you could find a solution to this which fixes chocolatey and is compatible with the other nuget v2 services.

@chris48s chris48s added bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs labels Apr 2, 2024
@chris48s chris48s added this pull request to the merge queue Apr 2, 2024
Merged via the queue into badges:master with commit 10b2f88 Apr 2, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chocolatey not found?
2 participants