Support undecorated static accessor in anonymous classes #16485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
JLHwung
force-pushed
the
support-anonymous-class-static-accessor
branch
from
dd0139f
to
7ff0a31
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56888 |
JLHwung
force-pushed
the
support-anonymous-class-static-accessor
branch
from
7ff0a31
to
c55226a
Compare
JLHwung
force-pushed
the
support-anonymous-class-static-accessor
branch
from
c55226a
to
ab03576
Compare
liuxingbaoyu
approved these changes
May 10, 2024
| @@ -15,3 +15,19 @@ class Foo { | |||
| Foo.#B = v; | |||
| } | |||
| } | |||
| Foo = class _Class { | |||
There was a problem hiding this comment.
The named evaluation is still preserved because Babel generates specific setFunctionName calls for those will-be-transformed classes.
It doesn't seem to be the case here?
nicolo-ribaudo
approved these changes
May 13, 2024
|
CI passed, I'm not sure about why it's still marked as yellow. |
nicolo-ribaudo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the class is named when Babel transforms an undecorated static accessor. The named evaluation is still preserved because Babel generates specific
setFunctionNamecalls for those will-be-transformed classes.