This repository has been archived by the owner on May 11, 2018. It is now read-only.
Refactor browser data parsing to handle families #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 3 3
Lines 196 196
Branches 59 59
=======================================
Hits 182 182
Misses 9 9
Partials 5 5Continue to review full report at Codecov.
|
|
I haven't started preparing the actual PR yet, fortunately. :) I'll have a look at this one. |
mgol
suggested changes
Mar 14, 2017
scripts/build-data.js
Outdated
| let bid; | ||
| let prevBid; | ||
|
|
||
| for (bid in rawBrowsers) { |
There was a problem hiding this comment.
This could be for (const bid in rawBrowsers) and then the above let bid declaration is not needed.
scripts/build-data.js
Outdated
| @@ -118,31 +161,26 @@ const getLowestImplementedVersion = ({ features }, env) => { | |||
|
|
|||
| const envTests = tests | |||
| .map(({ res: test, name, isBuiltIn }, i) => { | |||
|
|
|||
| if (name === "const/basic support") { | |||
|
Overall looks good, I have some minor remarks. |
yavorsky
reviewed
Mar 14, 2017
| .shift(); | ||
| .filter((t) => t.startsWith(env)) | ||
| // Babel assumes strict mode | ||
| .filter((test) => tests[i].res[test] === true || tests[i].res[test] === "strict") |
There was a problem hiding this comment.
We could merge 2 filters in 1 for perf, but it's just a nit and could be changed in separate PR aimed to optimize things like this.
yavorsky
approved these changes
Mar 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207.
And by refactor, it just means I just adapted compat-table's code for interpolating environments (essentially what #86 was doing).
One nice side effect is that this allows us to drop the
invertedEqualsEnvstuff, and may allow for some additional cleanup/hacks but will wait on that./cc: @mgol hope you weren't too far towards a fix, I was just looking at some code and realized it was a quick fix, would appreciate your eyes on this for a review!