Skip to content
This repository has been archived by the owner on May 11, 2018. It is now read-only.

Enable code coverage #200

Merged
merged 4 commits into from Mar 10, 2017
Merged

Conversation

oleksandr-kuzmenko
Copy link
Contributor

I propose to add code coverage to this repo.
Can someone from members enable integration with codecov.io?

@codecov-io
Copy link

codecov-io commented Mar 10, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@042cd5d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #200   +/-   ##
=========================================
  Coverage          ?   92.85%           
=========================================
  Files             ?        3           
  Lines             ?      196           
  Branches          ?       59           
=========================================
  Hits              ?      182           
  Misses            ?        9           
  Partials          ?        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 042cd5d...1bc6235. Read the comment docs.

@oleksandr-kuzmenko
Copy link
Contributor Author

codecov/project — No report found to compare against

I think it's OK for the first PR with codecov

@existentialism
Copy link
Member

Couple things:

  • Probably want to only include src, no sense in doing coverage on the data files, etc.

  • Should set all: true to include any files that don't have any tests

  • To get better coverage results, let's instrument the code via babel-plugin-instanbul (via BABEL_ENV/NODE_ENV).

@oleksandr-kuzmenko
Copy link
Contributor Author

@existentialism done.
But it looks like babel-plugin-instanbul does not work with Node.js 0.10/0.12. Should we support the Node.js 0.10/0.12?

@existentialism
Copy link
Member

existentialism commented Mar 10, 2017

@Alxpy for master we should use 3.1.2, and can bump to 4.0 on 2.0, if you don't mind making that change, I'll follow it up with some tweaks for CI/documentation

@existentialism
Copy link
Member

@Alxpy made a few tweaks, please review!

@oleksandr-kuzmenko
Copy link
Contributor Author

@existentialism LGTM!

@existentialism existentialism force-pushed the alxpy-patch-1 branch 5 times, most recently from a4d8ad4 to 976c6b4 Compare March 10, 2017 17:17
@existentialism
Copy link
Member

@Alxpy thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants