Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove babelrc from loader-specific options #667

Merged
merged 1 commit into from Aug 31, 2018

Conversation

adrienharnay
Copy link
Contributor

babelrc is supported by Babel, so it is not a loader-specific option.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Docs update

What is the current behavior? (You can also link to an open issue here)

/

What is the new behavior?

/

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact: /
  • Migration path for existing applications: /
  • Github Issue(s) this is regarding: /

Other information:

`babelrc` is [supported by Babel](https://babeljs.io/docs/en/options#babelrc), so it is not a loader-specific option.
@loganfsmyth loganfsmyth merged commit 053c9f6 into babel:master Aug 31, 2018
@loganfsmyth
Copy link
Member

Thanks!

@adrienharnay adrienharnay deleted the patch-1 branch August 31, 2018 15:55
@adrienharnay
Copy link
Contributor Author

No worries! Thanks for this awesome loader 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants