fix: change main entry to CJS dist #6348
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESM aware tools will only look in
exports
(and notmain
) when resolving a package. Therefore themain
entry point should always be a CJS file.I believe this is just an oversight in the
v1.x
branch since the last commit touchingpackage.json#main
was 10 years ago.This change will only affect older runtimes like
node@<=10
as well as tools likeresolve
. I'm not sure if those Node versions are officially supported, but this change should be ignored by all new runtime versions and bundlers.I found this due to a mocking library our tests were using that would fallback to the
resolve
package. In that case Node'srequire.resolve
would end up pointing to a different path thanresolve
:Similar things happen in Node 10 that cause the
require
to throw: