fix: regression which broke auto-destroying http requests #6322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
It appears that the
node:http
implementation in Bun setsautoDestroy: true
on requests whereas it looks like in NodeautoDestroy
is set tofalse
by default.This means that in Bun, the
if (req.destroyed)
check in axios was always being hit.The observed behavior was that the
axios(...)
promise was never resolving or throwing an exception.This looks like a regression introduced in #4787. Axios used to check
req.aborted
rather thanreq.destroyed
, which fixes this bug.Thanks!