Skip to content

Commit

Permalink
Removing unnecessary condition
Browse files Browse the repository at this point in the history
  • Loading branch information
nickuraltsev committed Nov 11, 2017
1 parent 1fa01fd commit b7d8d12
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/adapters/xhr.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ module.exports = function xhrAdapter(config) {
// DON'T do this for testing b/c XMLHttpRequest is mocked, not XDomainRequest.
if (process.env.NODE_ENV !== 'test' &&
typeof window !== 'undefined' &&
!window.XMLHttpRequest &&
window.XDomainRequest && !('withCredentials' in request) &&
!isURLSameOrigin(config.url)) {
request = new window.XDomainRequest();
Expand Down

2 comments on commit b7d8d12

@hanric
Copy link

@hanric hanric commented on b7d8d12 Jan 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nickuraltsev. Why is this unnecessary? It was merged not much time before here: #982

@mvaker
Copy link

@mvaker mvaker commented on b7d8d12 Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickuraltsev this condition was introduced to prevent the following issue: #982
If removed, this issue will appear again.

Please sign in to comment.