Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Moving
reset()
into lexical scope & calling from constructor()
& …
…`clear()`, fixing / simplifying `remove()`, fixes #7
- Loading branch information
Showing
5 changed files
with
41 additions
and
52 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
d0cdcfe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change, see https://travis-ci.org/fastify/fastify-rate-limit/builds/463812084?utm_source=github_status&utm_medium=notification
d0cdcfe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cemremengu ugh, didn't expect anyone to call that directly; will revert.
d0cdcfe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cemremengu
reset()
shouldn't be called, it should beclear()
if you follow the API back to 1.0; it will disappear again with 4.0 which will be equal to this commit.d0cdcfe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, will update the code on my side accordingly.
d0cdcfe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's my mistake. Sorry for the hassle, found the original commit and added a comment. The method shouldn't have been made public.
d0cdcfe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, thanks for your time and keep up the great work!
d0cdcfe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cemremengu 3.0.7 reverts the breaking change; it's been published but npm is not showing it yet. 4.0.0 is also published.