fix Skeleton browser applied padding #15421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to issue #15413, caused by `padding-inline-start` rule in browser default styles
|
Deploy preview for ant-design ready! Built with commit 7b2c878 |
Codecov Report
@@ Coverage Diff @@
## master #15421 +/- ##
==========================================
+ Coverage 94.19% 94.22% +0.03%
==========================================
Files 250 250
Lines 6647 6647
Branches 1910 1944 +34
==========================================
+ Hits 6261 6263 +2
+ Misses 385 383 -2
Partials 1 1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #15421 +/- ##
==========================================
+ Coverage 94.19% 94.22% +0.03%
==========================================
Files 250 250
Lines 6647 6647
Branches 1910 1944 +34
==========================================
+ Hits 6261 6263 +2
+ Misses 385 383 -2
Partials 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to issue #15413, caused by
padding-inline-startrule in browser default stylesFirst of all, thank you for your contribution! π
New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!
[δΈζηζ¨‘ζΏ / Chinese template]
π€ This is a ...
π» What's the background?
Major browsers like Chrome or Firefox in its default stylesheets include rule for
ulelement withpadding-inline-start: 40px, that breaks styling ofSkeletoncomponent.π‘ Solution
Override browser styles by resetting all paddings on Skeleton's unordered list element.
π Changelog description
I see no risks.
βοΈ Self Check before Merge