New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bad position of collapsible submenu in sider when collapsed #15409
Conversation
Deploy preview for ant-design ready! Built with commit f9d01ee |
为啥这 ci 不会跑的... |
我还以为这是个新的功能,在sider关闭的时候如果有menu打开就继续保持打开。 |
受控的时候应该打开,非受控关闭。 另外现在不仅打开,位置还留在原地。 |
Codecov Report
@@ Coverage Diff @@
## master #15409 +/- ##
==========================================
- Coverage 94.23% 94.19% -0.05%
==========================================
Files 250 250
Lines 6647 6651 +4
Branches 1930 1933 +3
==========================================
+ Hits 6264 6265 +1
- Misses 382 385 +3
Partials 1 1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #15409 +/- ##
==========================================
- Coverage 94.23% 94.19% -0.05%
==========================================
Files 250 250
Lines 6647 6651 +4
Branches 1930 1933 +3
==========================================
+ Hits 6264 6265 +1
- Misses 382 385 +3
Partials 1 1
Continue to review full report at Codecov.
|
这个有办法加用例么,这个组件细节很多,确实经常搞挂。 |
加是加了,应该有点用
|
被彩蛋搞怕了~ |
现在似乎会闪烁一下 |
而且现在在slider组件包裹状态下设置menu的inlineCollapsed是无效的 |
关于收缩闪烁还是有问题,更新后的版本3.15.1并没有解决,反而我降到3.15.0没有收缩闪现的状况 |
@ @afc163 |
3.15.1并没有解决 |
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
🤔 This is a ...
👻 What's the background?
Describe the source of requirement, like related issue link.
To close Bad position of collapsible submenu in sider when collapsed #15321.
Describe the problem and the scenario.
💡 Solution
How to fix the problem, and list final API implementation and usage sample if that is an new feature.
When migrating to new lifecycle methods, I forget to record the status of context, and caused this bug. Just make it up, and everything goes smoothly.
GIF or snapshot should be provided if includes UI/interactive modification.
📝 Changelog description
English description
Fix error rendering of SubMenu when Menu collapsed
Chinese description (optional)
修复 Menu 收缩后,SubMenu 异常渲染的问题
☑️ Self Check before Merge