Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad position of collapsible submenu in sider when collapsed #15409

Merged
merged 3 commits into from Mar 15, 2019
Merged

fix: bad position of collapsible submenu in sider when collapsed #15409

merged 3 commits into from Mar 15, 2019

Conversation

orzyyyy
Copy link
Contributor

@orzyyyy orzyyyy commented Mar 14, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

  1. Describe the source of requirement, like related issue link.

    To close Bad position of collapsible submenu in sider when collapsed #15321.

  2. Describe the problem and the scenario.

💡 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

    When migrating to new lifecycle methods, I forget to record the status of context, and caused this bug. Just make it up, and everything goes smoothly.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description

    Fix error rendering of SubMenu when Menu collapsed

  2. Chinese description (optional)

    修复 Menu 收缩后,SubMenu 异常渲染的问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Mar 14, 2019

Deploy preview for ant-design ready!

Built with commit f9d01ee

https://deploy-preview-15409--ant-design.netlify.com

@orzyyyy orzyyyy marked this pull request as ready for review March 14, 2019 08:54
@orzyyyy
Copy link
Contributor Author

orzyyyy commented Mar 14, 2019

为啥这 ci 不会跑的...

@ztplz
Copy link
Contributor

ztplz commented Mar 14, 2019

我还以为这是个新的功能,在sider关闭的时候如果有menu打开就继续保持打开。

@afc163
Copy link
Member

afc163 commented Mar 14, 2019

我还以为这是个新的功能,在sider关闭的时候如果有menu打开就继续保持打开。

受控的时候应该打开,非受控关闭。

另外现在不仅打开,位置还留在原地。

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #15409 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15409      +/-   ##
==========================================
- Coverage   94.23%   94.19%   -0.05%     
==========================================
  Files         250      250              
  Lines        6647     6651       +4     
  Branches     1930     1933       +3     
==========================================
+ Hits         6264     6265       +1     
- Misses        382      385       +3     
  Partials        1        1
Impacted Files Coverage Δ
components/menu/index.tsx 91.42% <100%> (+0.51%) ⬆️
components/_util/wave.tsx 84.61% <0%> (-2.89%) ⬇️
components/badge/index.tsx 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e028ec...198c01d. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #15409 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15409      +/-   ##
==========================================
- Coverage   94.23%   94.19%   -0.05%     
==========================================
  Files         250      250              
  Lines        6647     6651       +4     
  Branches     1930     1933       +3     
==========================================
+ Hits         6264     6265       +1     
- Misses        382      385       +3     
  Partials        1        1
Impacted Files Coverage Δ
components/menu/index.tsx 91.42% <100%> (+0.51%) ⬆️
components/_util/wave.tsx 84.61% <0%> (-2.89%) ⬇️
components/badge/index.tsx 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e028ec...f9d01ee. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Mar 14, 2019

这个有办法加用例么,这个组件细节很多,确实经常搞挂。

@orzyyyy
Copy link
Contributor Author

orzyyyy commented Mar 14, 2019

加是加了,应该有点用

@afc163 怎么感觉你人设变了,以前应该是更加性冷淡地说句,“来个测试用例。”
现在总觉得哪里不对...

@afc163
Copy link
Member

afc163 commented Mar 14, 2019

被彩蛋搞怕了~

@afc163 afc163 merged commit 1bb7d6c into ant-design:master Mar 15, 2019
@orzyyyy orzyyyy deleted the issue-15321 branch March 15, 2019 11:30
@ouzhou
Copy link

ouzhou commented Mar 21, 2019

现在似乎会闪烁一下
https://ant-design.gitee.io/components/layout-cn/#components-layout-demo-side
官方这个例子,你在打开一个子目录的状态下,点击收缩,会突然闪烁一下

@ouzhou
Copy link

ouzhou commented Mar 21, 2019

而且现在在slider组件包裹状态下设置menu的inlineCollapsed是无效的

@UnicornXU
Copy link

关于收缩闪烁还是有问题,更新后的版本3.15.1并没有解决,反而我降到3.15.0没有收缩闪现的状况

@UnicornXU
Copy link

@ @afc163

@ouzhou
Copy link

ouzhou commented Apr 3, 2019

3.15.1并没有解决

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad position of collapsible submenu in sider when collapsed
5 participants