fix(Layout): disable hasSider when specifically declared
#15396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some situation `Sider` is deeply rendered in Children of `Layout`, and if we don't want to judge whether `Layout` has sider, the attr `hasSider` set to `false` should properly work. However `hasSider || this.state.siders.length > 0` will ignore `hasSider` when it is `false`.
|
Deploy preview for ant-design ready! Built with commit 2b7fce3 |
1 similar comment
|
Deploy preview for ant-design ready! Built with commit 2b7fce3 |
Codecov Report
@@ Coverage Diff @@
## master #15396 +/- ##
==========================================
+ Coverage 94.23% 94.26% +0.03%
==========================================
Files 250 250
Lines 6645 6645
Branches 1943 1929 -14
==========================================
+ Hits 6262 6264 +2
+ Misses 382 380 -2
Partials 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
🤔 This is a ...
👻 What's the background?
Just find a bug (probably) when coding
In some situation
Sideris deeply rendered in Children ofLayout,and if we don't want to judge whether
Layouthas sider, the attrhasSiderset to
falseshould properly work. HoweverhasSider || this.state.siders.length > 0will ignore
hasSiderwhen it isfalse.💡 Solution
Judge
hasSideris type of Boolean first.📝 Changelog description
Fix a bug:
Layouthas classnameant-layout-has-sidereven ifhasFixeris set tofalsewhensideris one of its descendants.修复即使在指定
Layout的hasSider属性为false的时候依然会加ant-layout-has-sider的classname的问题☑️ Self Check before Merge