fix: should color style works on Badge #15356
Conversation
|
很奇怪的本地测试没报错 |
|
Deploy preview for ant-design ready! Built with commit 0039ea0 |
|
@zombieJ ci broken |
components/badge/demo/status.md
Outdated
| @@ -33,6 +37,8 @@ ReactDOM.render( | |||
| <Badge status="processing" text="Processing" /> | |||
| <br /> | |||
| <Badge status="warning" text="Warning" /> | |||
| <br /> | |||
| <Badge style={style} status="success" text="Success" /> | |||
| // https://github.com/ant-design/ant-design/issues/15349 | ||
| it('should color style works on Badge', () => { | ||
| const wrapper = render(<Badge style={{ color: 'red' }} status="success" text="Success" />); | ||
| expect(wrapper.find('.ant-badge-status-text').get(0).attribs.style).toBe('color:red'); |
There was a problem hiding this comment.
=> xxx.props().style.color & toBe('red')
merge master |
master 跪了。 |
|
嗯，enzyme bug：enzymejs/enzyme#2046 |
Codecov Report
@@ Coverage Diff @@
## master #15356 +/- ##
==========================================
+ Coverage 94.27% 94.27% +<.01%
==========================================
Files 250 250
Lines 6640 6642 +2
Branches 1940 1927 -13
==========================================
+ Hits 6260 6262 +2
Misses 379 379
Partials 1 1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #15356 +/- ##
==========================================
+ Coverage 94.27% 94.27% +<.01%
==========================================
Files 250 250
Lines 6640 6642 +2
Branches 1940 1927 -13
==========================================
+ Hits 6260 6262 +2
Misses 379 379
Partials 1 1
Continue to review full report at Codecov.
|
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
🤔 This is a ...
👻 What's the background?
Describe the source of requirement, like related issue link.
Describe the problem and the scenario.
💡 Solution
How to fix the problem, and list final API implementation and usage sample if that is an new feature.
GIF or snapshot should be provided if includes UI/interactive modification.
📝 Changelog description
English description
Chinese description (optional)
☑️ Self Check before Merge