Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list item style #15328

Merged
merged 5 commits into from Mar 11, 2019
Merged

Fix list item style #15328

merged 5 commits into from Mar 11, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 11, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

  1. Describe the source of requirement, like related issue link.

close #15329

  1. Describe the problem and the scenario.

horizonal List should align center

version codesandbox good or bad
3.14.1 https://codesandbox.io/s/q3qykjl40q
3.15.0 https://codesandbox.io/s/vq4zokpz8l

horizontal List should show extra in right edge

version codesandbox good or bad
3.14.1 https://codesandbox.io/s/61pl82lwvk
3.15.0 https://codesandbox.io/s/z36m1693nx

horizontal List should be flex container when no string nodes

version codesandbox good or bad
3.14.1 https://codesandbox.io/s/lz1lq824l
3.15.0 https://codesandbox.io/s/znoq759zmx

vertical List should always be flex container

version codesandbox good or bad
3.14.1 https://codesandbox.io/s/m9qx42l6kj
3.15.0 https://codesandbox.io/s/848r52kk50

📝 Changelog description

Describe changes from user side, and list all potential break changes or other risks.

  1. English description
  1. Chinese description (optional)

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Mar 11, 2019

Deploy preview for ant-design ready!

Built with commit fc58fd2

https://deploy-preview-15328--ant-design.netlify.com

@afc163 afc163 marked this pull request as ready for review March 11, 2019 14:33
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #15328 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15328      +/-   ##
==========================================
+ Coverage    94.1%   94.11%   +<.01%     
==========================================
  Files         250      250              
  Lines        6637     6643       +6     
  Branches     1906     1907       +1     
==========================================
+ Hits         6246     6252       +6     
  Misses        390      390              
  Partials        1        1
Impacted Files Coverage Δ
components/list/index.tsx 97.26% <ø> (ø) ⬆️
components/list/Item.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 780bb7d...fc58fd2. Read the comment docs.

@afc163 afc163 merged commit 5f4f8b0 into master Mar 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-list-item-style branch March 11, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 List style problem in 3.15.0
1 participant