Fix stack of undefined issue #5513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't upgrade the version of Selenium without transitioning off the control flow and breaking a bunch of people. Chrome v75 introduced the new W3C actions API. Unfortunately, we can't update to support that API without introducing other breakages, so v74 is the last version of Chrome that will work with Protractor 5. You can download a Chrome v74 snapshot from https://commondatastorage.googleapis.com/chromium-browser-snapshots/Linux_x64/638880/chrome-linux.zip You might also need to pass "--no-sandbox" flag to Chrome
Doing this automatically means we can't pin the version of webdriver that we use in CI. Instead, we run update in the circle config.
…oxy to 4.5.4 travis_wait is not needed if the sauce connect proxy logs are written to stdout. This makes debugging proxy problems from the CI logs much easier. This commit also updates the debugging command to use the `--doctor` flag. Other changes include: 1. Upgrade sauce-connect proxy from 4.4.1 to 4.5.4
Optimist has been deprecated over 2 years ago as has a security vulnerability. With this change we use it's successor `yargs`. Closes: angular#5413
BREAKING CHANGE: Node.Js version 6 and 8 are no longer supported. Please update to Node.Js 10+ Closes angular#5431
BREAKING CHANGE: Debugger and explore methods are not compatable with Node 8+. Use `debugger` keyword instead. See: https://goo.gl/MvWqFh
utils.puts is no longer available in Node.JS 12
Protractor debugger and element explorer cannot be used for Node.js 8+ and were removed in version 7.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the default logic, this
errobject should be anObjectorString. But in my case when theerris undefined or null, this code will throw an issue as below image. I add a logic to check if theerris not null or undefined.