Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logger): close opened file descriptor in '.setWrite()' (for unit tests on windows) #5411

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(logger): close opened file descriptor in '.setWrite()' (for unit tests on windows) #5411

wants to merge 1 commit into from

Commits on Mar 15, 2020

  1. fix(logger): close opened fd in '.setWrite()' 

    windows does not really unlink file, if fd is opened.
(see https://stackoverflow.com/a/20801823/2519073)
the unit tests failing because of this
    @yadimon
    yadimon committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    fb3d962 View commit details
    Browse the repository at this point in the history