Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/lambdatest grid #5260

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

psych0der
Copy link

@psych0der psych0der commented Jun 14, 2019

https://www.LambdaTest.com

PR to add LambdaTest support in Protractor

Description

Add LambdaTest integration support in Protractor. LambdaTest provides a distributed selenium grid which helps you to perform testing on a wide range of browsers on 4+ windows platform and 6+ mac platform.

Motivation and Context

Protractor is a great end to end testing framework and LambdaTest is an amazing cloud browser provider with awesome selenium support. The alliance between the two obviously seems natural. This feature will provide tight integration within Protractor to perform selenium based testing on a wide range of browsers on the cloud which will complement the already existing great tooling and the ecosystem provided by Protractor.
In addition to that, many of our customers are already using Protractor and want test on LambdaTest platform from within the framework

How Has This Been Tested?

  • Successfully ran existing test cases against the feature commits
  • Ran an extensive test suite on LambdaTest browsers using the integrated Protracter branch
  • Ran sample Protracter test cases using the integrated branch to verify the sanity of the existing functionality
  • Followed steps mentioned in DEVELOPER.md to do general tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This change follows the natural way of adding integration support for a 3rd party testing infrastructure provider.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@psych0der
Copy link
Author

I signed it!

2 similar comments
@psych0der
Copy link
Author

I signed it!

@kanhaiya15
Copy link

I signed it!

@psych0der psych0der closed this Jul 23, 2019
@psych0der psych0der reopened this Jul 23, 2019
@psych0der
Copy link
Author

I signed it!

2 similar comments
@kanhaiya15
Copy link

I signed it!

@kanhaiya15
Copy link

I signed it!

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@kanhaiya15
Copy link

I signed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants